Repository navigation
Count leaked processes in one line; list them with --show-leaked-processes - #15
Open
richardcocks wants to merge 1 commit into
Open
richardcocks wants to merge 1 commit into
richardcocks wants to merge 1 commit into
Conversation
…esses The end-of-run leak report printed one "left ... running" line per leak. A suite with a known leaky fixture repeats the same wall of lines after every run, which is noise in watch mode. By default the report is now a single line counting the leaks and naming the flag that lists them; the per-leak lines, named by the test and by what started it, come back with --show-leaked-processes. The line also moves from after the summary to before the failures list, so a one-line notice is not lost under long failure details. Crash reports stay after the summary. runner.run and its helpers take the parsed config.Config instead of a growing list of positional flags, which collapses the six repeated call sites in vouch.gleam. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The end-of-run leak report printed one
vouch: <test> left <mfa> runningline per leaked process. A suite with a known leaky fixture repeats the same wall of lines after every run, which is noise in watch mode.By default the report is now a single line counting the leaks and naming the flag that lists them:
New flag
--show-leaked-processesbrings back the per-leak lines, named by the test and by what started it. On the JavaScript target it gets the same "has no effect" warning as its siblings.The line moves from after the summary to after the result lines and before the
Failures:block, so a one-line notice is not lost under long failure details. Crash reports (--show-crash-reports) and unattributed crash reports stay after the summary.runner.runand its helpers now take the parsedconfig.Configinstead of a growing list of positional flags, collapsing the six repeated call sites invouch.gleam. Internal API only.--keep-leaked-processesoutput follows the same count-only default.README and CHANGELOG are deliberately untouched in this PR.
Test plan
gleam teston Erlang: 104 passed (includes the e2e that runs the playground in default,--show-leaked-processesand--keep-leaked-processesmodes, and asserts the count line lands beforeFailures:)gleam test --target javascript: 79 passedconfig_show_leaked_processes_testgleam format --checkclean🤖 Generated with Claude Code