Skip to content

OU-656: UIPlugin logging-view-plugin new stream for OCP 4.22 Patternfly v6#1046

Open
zhuje wants to merge 1 commit intorhobs:mainfrom
zhuje:ou656-uiplugin-logging-pf6-migration
Open

OU-656: UIPlugin logging-view-plugin new stream for OCP 4.22 Patternfly v6#1046
zhuje wants to merge 1 commit intorhobs:mainfrom
zhuje:ou656-uiplugin-logging-pf6-migration

Conversation

@zhuje
Copy link
Copy Markdown
Contributor

@zhuje zhuje commented Mar 30, 2026

JIRA

https://redhat.atlassian.net/browse/OU-656

Related PR

New image stream for uiplugin >> logging-view-plugin because of Patternfly v6 migration needed in OCP v4.22.

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Mar 30, 2026

@zhuje: This pull request references OU-656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

JIRA

https://redhat.atlassian.net/browse/OU-656

New image stream for uiplugin >> logging-view-plugin because of Patternfly v6 migration needed in OCP v4.22.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from PeterYurkovich March 30, 2026 20:35
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhuje
Once this PR has been reviewed and has the lgtm label, please assign jan--f for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from simonpasquier March 30, 2026 20:35
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

📝 Walkthrough

Walkthrough

The change introduces version-based UI plugin image selection where OpenShift versions before v4.22 use the ui-logging-pf5 image at v6.1.5, while v4.22 and later use the updated ui-logging image at v6.2.0. Default image mappings and compatibility matrix are updated accordingly with matching test coverage.

Changes

Cohort / File(s) Summary
Operator Default Images
cmd/operator/main.go
Added new ui-logging-pf5 default image key (v6.1.5) and updated ui-logging default image from v6.1.5 to v6.2.0.
UI Plugin Compatibility Matrix
pkg/controllers/uiplugin/compatibility_matrix.go
Added two new TypeLogging compatibility ranges: v4.15–v4.22 (exclusive) mapping to ui-logging-pf5 image, and v4.22+ mapping to ui-logging image. Both ranges support dev-console, alerts, dev-alerts features with GeneralAvailability status.
Compatibility Matrix Tests
pkg/controllers/uiplugin/compatibility_matrix_test.go
Updated existing test cases for v4.15 cluster versions to expect ui-logging-pf5 image. Added new test cases for v4.21.1 (expects ui-logging-pf5) and v4.22 variants (expect ui-logging).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a new image stream for the logging-view-plugin UI plugin to support PatternFly v6 migration for OCP 4.22.
Description check ✅ Passed The PR description is related to the changeset, referencing a JIRA ticket and explaining the motivation for adding a new image stream for the logging-view-plugin due to PatternFly v6 migration in OCP v4.22.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Mar 30, 2026

@zhuje: This pull request references OU-656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

JIRA

https://redhat.atlassian.net/browse/OU-656

Related PR

New image stream for uiplugin >> logging-view-plugin because of Patternfly v6 migration needed in OCP v4.22.

/hold
March 30, 2026
quay.io is down, and I couldn't push the image quay.io/openshift-observability-ui/logging-view-plugin:v6.2.0. Once the quay.io servers are up, I'll push the new logging-view-plugin image, which will include this PR: openshift/logging-view-plugin#358.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Mar 30, 2026

@zhuje: This pull request references OU-656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

JIRA

https://redhat.atlassian.net/browse/OU-656

Related PR

New image stream for uiplugin >> logging-view-plugin because of Patternfly v6 migration needed in OCP v4.22.

/hold
March 30, 2026
quay.io is down, and I couldn't push the image quay.io/openshift-observability-ui/logging-view-plugin:v6.2.0. Once the quay.io servers are up, I'll push the new logging-view-plugin image, which will include this PR: openshift/logging-view-plugin#358.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Mar 30, 2026

@zhuje: This pull request references OU-656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

JIRA

https://redhat.atlassian.net/browse/OU-656

Related PR

New image stream for uiplugin >> logging-view-plugin because of Patternfly v6 migration needed in OCP v4.22.

/hold
March 30, 2026
quay.io is down, and I couldn't push the image quay.io/openshift-observability-ui/logging-view-plugin:v6.2.0. Once the quay.io servers are up, I'll push the new logging-view-plugin image, which will include this PR: openshift/logging-view-plugin#358 for the Patternfly v6 migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Mar 31, 2026

@zhuje: This pull request references OU-656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

JIRA

https://redhat.atlassian.net/browse/OU-656

Related PR

New image stream for uiplugin >> logging-view-plugin because of Patternfly v6 migration needed in OCP v4.22.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zhuje
Copy link
Copy Markdown
Contributor Author

zhuje commented Mar 31, 2026

Just push quay.io/openshift-observability-ui/logging-view-plugin:v6.2.0

@zhuje
Copy link
Copy Markdown
Contributor Author

zhuje commented Mar 31, 2026

/retest

@etmurasaki
Copy link
Copy Markdown
Contributor

OBO1.5.0-a testing image:

bundle: http://quay.io/rh-ee-emurasak/observability-operator-bundle:1.5.0-a , containing ui-logging: http://quay.io/jezhu/logging-view-plugin:ou565-mar30

OBO-1.5.0-b testing image:
Bundle: http://quay.io/rh-ee-emurasak/observability-operator-bundle:1.5.0-b containing the original main.go

Tested against 4.21, 4.22 and 5.0. (4.23 I couldn’t provision) and logging UIPlugin got installed successfully and with correct expected versions.

@etmurasaki
Copy link
Copy Markdown
Contributor

/label qe-approved

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 31, 2026

@etmurasaki: The label(s) qe-approved cannot be applied, because the repository doesn't have them.

Details

In response to this:

/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants