Skip to content

[WIP] Facilities Revamp - Sleek time blocks#764

Open
marcus-ong-qy wants to merge 1 commit into
develfrom
revamp-facilities/sleek-time-blocks
Open

[WIP] Facilities Revamp - Sleek time blocks#764
marcus-ong-qy wants to merge 1 commit into
develfrom
revamp-facilities/sleek-time-blocks

Conversation

@marcus-ong-qy

Copy link
Copy Markdown
Contributor

Resolves: #762

Proposed change to the time blocks height
image
image

  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in** the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"

@vercel

vercel Bot commented Jan 3, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rhapp ✅ Ready (Inspect) Visit Preview Jan 3, 2023 at 1:11AM (UTC)

@cjunxiang

cjunxiang commented Jan 30, 2023

Copy link
Copy Markdown
Contributor
  1. UI suggestion: add a counter to "View my bookings (2)"
  2. UX suggestion: select facility page to be permanent component under the action buttons, so no unnecessary reloading.
  3. bug: visual bug in header (no back button, and text title pushes everything aside)
  4. UX: if user has no rights to book, grey out "book facility" button.
  5. "edit icon" on top right of "select date to view" intended? no idea what that does
  6. (on main branch) back button exists on facility booking page, shouldn't need it trhere.

@marcus-ong-qy

Copy link
Copy Markdown
Contributor Author
  1. UI suggestion: add a counter to "View my bookings (2)"
  2. UX suggestion: select facility page to be permanent component under the action buttons, so no unnecessary reloading.
  3. bug: visual bug in header (no back button, and text title pushes everything aside)
  4. UX: if user has no rights to book, grey out "book facility" button.
  5. "edit icon" on top right of "select date to view" intended? no idea what that does
  6. (on main branch) back button exists on facility booking page, shouldn't need it trhere.

Header title overflow should be fixed on the main branch cos this branch haven't update yet. Shall KIV the other suggestions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FE] [IDEA] Make time blocks sleek 🐍

2 participants