Create about us page#18
Open
lyuanww wants to merge 11 commits into
Open
Conversation
marcus-ong-qy
suggested changes
Mar 9, 2023
| const PreviewText = styled.div<{ hasAnimation?: boolean; fontType: FontType }>` | ||
| ${fontTypeCss} | ||
| margin-top: 20px; | ||
| color: ${(props) => props.theme.palette.common.gray}; |
Comment on lines
+5
to
+12
| const fadeIn = keyframes` | ||
| 0% { | ||
| opacity: 0; | ||
| } | ||
| 100% { | ||
| opacity: 1; | ||
| } | ||
| ` |
| "start": " next build && npm run open-browser && next start", | ||
| "lint": "next lint", | ||
| "open-browser": "start http://localhost:3000" | ||
| "open-browser": "open http://localhost:3000" |
Contributor
There was a problem hiding this comment.
remove, and update your branch from main!
| onClick: undefined, | ||
| } | ||
|
|
||
| export default function Preview(props: Props) { |
Contributor
There was a problem hiding this comment.
Rename the component to something useful e.g. InformationComponent
Change the name of this file accordingly also, should match the name of the default component export
| color: ${(props) => props.theme.palette.common.black}; | ||
| ` | ||
|
|
||
| export default function FollowUs() { |
Contributor
There was a problem hiding this comment.
rename to like SocialMediaLinks or smthg
| color: ${(props) => props.theme.palette.common.black}; | ||
| ` | ||
|
|
||
| export default function FollowUs() { |
Contributor
There was a problem hiding this comment.
use arrow notation for functions!
Suggested change
| export default function FollowUs() { | |
| export FollowUs = () => { |
Comment on lines
+25
to
+27
| <Icon></Icon> | ||
| <Icon></Icon> | ||
| <Icon></Icon> |
Comment on lines
+1
to
+9
| /** | ||
| * # Create About Us Page | ||
| * | ||
| * Path: `/aboutus` | ||
| * | ||
| * ## Page Description | ||
| * This page is accessed after the user has clicked on the About Us button on the navigation bar. | ||
| * | ||
| */ |
Contributor
There was a problem hiding this comment.
Good job! However docs should be placed just above the main export function, not at the top of the file
Comment on lines
+7
to
+8
| * This page is accessed after the user has clicked on the About Us button on the navigation bar. | ||
| * |
Contributor
There was a problem hiding this comment.
Ok for now, but when the page is filled do describe more on what the page shows (e.g. shows a brief intro to hall etc.)
cjunxiang
reviewed
Mar 2, 2024
| "noImplicitAny": false | ||
| }, | ||
| "include": ["next-env.d.ts", "**/*.ts", "**/*.tsx"], | ||
| "include": ["next-env.d.ts", "**/*.ts", "**/*.tsx", "components/AboutUsInfoComponenttsx"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue#16 Resolved