Draft
Conversation
rgoulter
force-pushed
the
keymap-artseyio
branch
2 times, most recently
from
28a7aae to
c3ed306
Compare
rgoulter
force-pushed
the
keymap-artseyio
branch
from
be55aaa to
be2821f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
rgoulter
force-pushed
the
keymap-artseyio
branch
4 times, most recently
from
a3c35fa to
b665e79
Compare
rgoulter
force-pushed
the
keymap-artseyio
branch
4 times, most recently
from
da9dc49 to
cddb769
Compare
26 tasks
rgoulter
commented
Sep 24, 2025
rgoulter
commented
Sep 24, 2025
Comment on lines
+382
to
+389
| BtProfile1 = K.NO, | ||
| BtProfile2 = K.NO, | ||
| BtProfile3 = K.NO, | ||
| BtProfile4 = K.NO, | ||
| BtProfile5 = K.NO, | ||
| BtProfile6 = K.NO, | ||
| BtModeBluetooth = K.NO, | ||
| BtModeUsb = K.NO, |
Owner
Author
There was a problem hiding this comment.
I'm not sure if it makes sense to have a smart_keymap::key for this, or to just suggest use Custom/Callback keys.
rgoulter
force-pushed
the
keymap-artseyio
branch
6 times, most recently
from
90123d4 to
c2fa3f8
Compare
rgoulter
commented
Sep 28, 2025
| & { | ||
| layered = | ||
| let B = K.layer_mod.set_active_layers_to [BASE_] in | ||
| [B, B, B, B, B, B, B], |
Owner
Author
There was a problem hiding this comment.
I'm not sure if this code is clearer than having std.array.generate construct an array at the specific index would be.
rgoulter
force-pushed
the
keymap-artseyio
branch
2 times, most recently
from
0d869f8 to
72093c7
Compare
rgoulter
force-pushed
the
keymap-artseyio
branch
from
72093c7 to
9cdb7a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Not covered by tests; the "passing status checks" is irrelevant).