Fix candidate gating on PSPL fit quality - #2
Draft
NunotaKansuke wants to merge 6 commits into
Draft
Conversation
Removed known quirks section from README.
Added a description for the automated event tracker.
Removed outdated command line instructions and testing section from README.
Fix candidate gating on PSPL fit quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_candidateflag on the PSPL fit-quality decision.Root cause
fit_pspl_candidatealready returnsis_candidate=Falsewhen the reduced PSPL chi-square exceedsgood_pspl_chi2, but the pipeline ignored that value and derived the final flag only from the bump scan and vetoes. This allowed poor PSPL fits to be reported as candidates.Validation
pytest -q— 16 passedruff check src tests— passedNunotaKansuke/aethramainbefore opening this PR.The bug was reproduced on a Roman simulation event where
chi2_red_pspl=2.979exceeded the default threshold of2.5, while the pipeline previously returnedis_candidate=True.