Skip to content

fix(setup): unbreak desktop-client pre-flight on Debian/Ubuntu #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rexlunae merged 1 commit into from
Aug 25, 2026
Merged

fix(setup): unbreak desktop-client pre-flight on Debian/Ubuntu #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- **setup.sh no longer refuses to build the desktop client on Debian/Ubuntu.**
The WebKitGTK/JavaScriptCore/libxdo pre-flight gate checked all three with
pkg-config, but Debian and Ubuntu's `libxdo-dev` package ships no
`libxdo.pc` at all (just `xdo.h` and the `.so`) — so on an Ubuntu box with
every required package correctly installed, setup still aborted with "dev
packages not found" even though `cargo build` would have succeeded: the
actual link requirement is plain `-lxdo` (`libxdo-sys`'s entire build script
is `cargo:rustc-link-lib=xdo`; no pkg-config involved). libxdo is now
detected by asking the compiler whether `-lxdo` resolves when pkg-config has
nothing to say, which also covers distros that ship the pc file under a
different name. The combined check was split into per-package probes, so a
failure now names the missing piece (JavaScriptCore 4.1 vs libxdo) with its
own install line instead of lumping both together. Two adjacent latent bugs
fixed in passing: `libjavascriptcoregtk-4.1-dev` — which owns the
`javascriptcoregtk-4.1.pc` file the build's system-deps probe needs — is now
installed explicitly instead of being relied on as a transitive Depends of
`libwebkit2gtk-4.1-dev`; and Fedora's xdo dev package is installed as its
current name `libxdo-devel` (falling back to `xdotool-devel`, since the
rename left older releases with no match for the new name).

### Added

- **Configurable model-call deadline.** The gateway's per-turn model call
Expand Down
58 changes: 48 additions & 10 deletions scripts/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,20 @@ esac

has() { command -v "$1" &>/dev/null; }

# Whether libxdo can actually be linked against — which is all rustyclaw-desktop
# needs of it (muda → libxdo-sys, whose entire build script is
# `cargo:rustc-link-lib=xdo`; no headers are probed, no pkg-config consulted).
# Several distros ship no libxdo.pc for pkg-config to find — notably
# Debian/Ubuntu, where libxdo-dev installs only xdo.h and the .so — so when
# pkg-config comes up empty, ask the compiler whether `-lxdo` resolves.
have_libxdo() {
if pkg-config --exists "libxdo" 2>/dev/null; then
return 0
fi
has cc || return 1
printf 'int main(void){return 0;}\n' | cc -xc - -o /dev/null -lxdo 2>/dev/null
}

# ── Desktop launcher integration ────────────────────────────────────────────
# Register the desktop client with the OS application launcher, with the app
# icon: a .desktop entry + hicolor icon on Linux, a ~/Applications/RustyClaw.app
Expand Down Expand Up @@ -757,17 +771,26 @@ if should_install rustyclaw; then
if has apt-get; then
info "Installing Debian/Ubuntu build deps..."
sudo apt-get update -qq
# libjavascriptcoregtk-4.1-dev is a Depends of
# libwebkit2gtk-4.1-dev today, but it owns the
# javascriptcoregtk-4.1.pc file the build's system-deps probe
# needs, so it is named explicitly rather than hoped for.
sudo apt-get install -y -qq \
build-essential pkg-config libssl-dev \
libglib2.0-dev libgtk-3-dev libwebkit2gtk-4.1-dev libxdo-dev \
libglib2.0-dev libgtk-3-dev \
libwebkit2gtk-4.1-dev libjavascriptcoregtk-4.1-dev libxdo-dev \
2>/dev/null || true
success "Debian/Ubuntu build deps ready"
elif has dnf; then
info "Installing Fedora/RHEL build deps..."
sudo dnf install -y -q \
gcc pkg-config openssl-devel \
glib2-devel gtk3-devel webkit2gtk4.1-devel xdotool-devel \
glib2-devel gtk3-devel webkit2gtk4.1-devel \
2>/dev/null || true
# Newer Fedora releases split xdotool and ship the xdo dev
# files as libxdo-devel; older ones called it xdotool-devel.
sudo dnf install -y -q libxdo-devel 2>/dev/null \
|| sudo dnf install -y -q xdotool-devel 2>/dev/null || true
success "Fedora/RHEL build deps ready"
elif has pacman; then
info "Installing Arch build deps..."
Expand Down Expand Up @@ -818,16 +841,31 @@ if should_install rustyclaw; then
# JavaScriptCore + WebKitGTK 4.1 + libxdo; if they're
# missing the cargo build fails only after several minutes
# of compile time, so fail fast here with install
# instructions instead.
if pkg-config --exists "javascriptcoregtk-4.1" && pkg-config --exists "libxdo"; then
# instructions instead. The two probes are reported
# separately: Debian/Ubuntu's libxdo-dev ships no
# libxdo.pc, so a single combined pkg-config check would
# call a perfectly buildable machine incomplete.
jsc_found=false
pkg-config --exists "javascriptcoregtk-4.1" && jsc_found=true
xdo_found=false
have_libxdo && xdo_found=true

if [[ "$jsc_found" == true && "$xdo_found" == true ]]; then
success "JavaScriptCore + libxdo development packages detected"
else
err "WebKitGTK/JavaScriptCore 4.1 and libxdo dev packages not found — rustyclaw-desktop cannot build without them"
err "Install them, e.g.:"
err " Debian/Ubuntu: sudo apt-get install libwebkit2gtk-4.1-dev libxdo-dev"
err " Fedora: sudo dnf install webkit2gtk4.1-devel xdotool-devel"
err " Arch: sudo pacman -S webkit2gtk-4.1 xdotool"
err " Alpine: sudo apk add webkit2gtk-dev xdotool-dev"
if [[ "$jsc_found" == false ]]; then
err "JavaScriptCore 4.1 development files not found — rustyclaw-desktop cannot build without them"
err " Debian/Ubuntu: sudo apt-get install libjavascriptcoregtk-4.1-dev"
err " Fedora: sudo dnf install javascriptcoregtk4.1-devel"
err " Arch/Alpine: included in webkit2gtk-4.1 / webkit2gtk-dev"
fi
if [[ "$xdo_found" == false ]]; then
err "libxdo development files not found (no linker-visible -lxdo) — rustyclaw-desktop cannot build without it"
err " Debian/Ubuntu: sudo apt-get install libxdo-dev"
err " Fedora: sudo dnf install libxdo-devel"
err " Arch: sudo pacman -S xdotool"
err " Alpine: sudo apk add xdotool-dev"
fi
err ""
err "Or build without the GUI client: --clients cli gateway tui"
exit 1
Expand Down
Loading