Repository navigation
Retry the deployment smoke checks when a new revision drops a connection - #208
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy of
mainafter today's data adoption failed twice, and both times rolled back. The first attempt failed insmoke-deployment.mjs: the request after/use-cases/was reset by the new revision while it warmed up (TypeError: terminated,ECONNRESET). The failed-only re-run could not find the first attempt's build artifact.The candidate revision itself is fine. Fetched directly on its tagged URL, every smoke path returns 200 in under 2 seconds.
Fix
Each smoke check now goes through
fetchWithRetry, the same helper the live catalogue probe uses since #200. A dropped connection or a stalled body is retried up to three times. A real failure, such as a 503 on every attempt or a wrong page, still fails the deploy.Tested
tests/deployment-smoke.test.tspasses (20 tests), including a new test where a connection resets once and is then retried.tests/deployment.test.tspasses (24 tests).