PRSS#2
Closed
mrjackv wants to merge 8 commits into
Closed
Conversation
Closed
Add an additional `CMakeLists.txt` file which allows building nanobind as a standalone project, installing `libnanobind.so` under `/lib` and headers under `/include`.
Drop the use of `typeid` and `std::type_info` from the codebase, they are now replaced with a thin shim through `shimTypeid<T>` and `shim::type_info`.
Search and replace all uses of uses of `std::type_info` and
`typeid(...)` from the codebase and replace them with the shimmed
functions/classes implemented in the previous commit. This commit can
be regenerated during a rebase by running the following command:
```
find src include -type f \
\( -name '*.h' -or -name '*.cpp' \) \
-exec sed -i \
-e 's;std::type_info;shim::type_info;g' \
-e 's;typeid(\*ptr);typeidShim(*ptr);g' \
-e 's;typeid(\([^)]\+\));typeidShim<\1>();g' {} \;
```
Drop the use of exceptions from the codebase. Where needed add an `abort`.
Search and replace all exception-related code (`try`, `catch`, `throw`)
and replace their use with functions/classes implemented in the previous
commit. This commit can be regenerated during a rebase by running the
following command:
```
find src include -type f \
\( -name '*.h' -or -name '*.cpp' \) \
-exec sed -i \
-e 's|try {|if (true) {|g' \
-e 's|catch (.*&\s*\(.\+\)) {|if (false) { shim::exception_placeholder \1;|g' \
-e 's|catch (.*) {|if (false) {|g' \
-e 's|throw \(.*\);$|throwShim(\1);|g' {} \;
```
Add extra compiler flags that make the compiler stricter.
Remove the `hidden` attribute from the nanobind namespace, as it was causing linking problems.
Author
|
Closing as this PR was merged as part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is just a rebase on top of the
basebranch, no changes have been made