Open
Conversation
aelmahmoudy
force-pushed
the
e12b3_shells_and_users
branch
from
9167690 to
f70987c
Compare
aelmahmoudy
changed the title
* The return value didn't sort the shells, sorted(shells.list,key=len) does nothing, as the length of each tuple is 2: the key & the value, while you obviously wanted the length of the user list * The exercise also requested listing the usernames '(sorted alphabetically)'
aelmahmoudy
force-pushed
the
e12b3_shells_and_users
branch
from
f70987c to
2cd10e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sorted(shells.list,key=len) does nothing, as the length of each
tuple is 2: the key & the value, while you obviously wanted the length
of the user list
alphabetically)'