Skip to content

Removed focussed option and simplified zsh completion - #415

Closed
DogeTheBeast wants to merge 6 commits into
resurrecting-open-source-projects:masterfrom
DogeTheBeast:zsh-completion-cleanup
Closed

DogeTheBeast wants to merge 6 commits into
resurrecting-open-source-projects:masterfrom
DogeTheBeast:zsh-completion-cleanup

Conversation

@DogeTheBeast

@DogeTheBeast DogeTheBeast commented Jun 2, 2025 •

Copy link
Copy Markdown
Contributor
  • Removed the alternate spelling of focused (ie focussed) from the completion menu for zsh
  • Fixed mutually exclusive completion options (as listed in the TODO.md)
  • Added default installation of completion scripts for zsh and bash.

@DogeTheBeast
DogeTheBeast marked this pull request as ready for review June 2, 2025 05:43
@DogeTheBeast
DogeTheBeast marked this pull request as draft June 2, 2025 05:49
Comment thread etc/zsh-completion/_scrot
Comment thread src/options.c
@DogeTheBeast
DogeTheBeast marked this pull request as ready for review June 4, 2025 21:37
@DogeTheBeast
DogeTheBeast requested a review from N-R-K June 5, 2025 17:02
@N-R-K

N-R-K commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

Looks good, thanks. Merged in 0af6d20 and 521be31.

@N-R-K N-R-K closed this Jun 9, 2025
@N-R-K

N-R-K commented Mar 5, 2026 •

Copy link
Copy Markdown
Collaborator

This breaks make distcheck because it's trying to install the files into /usr/share and ignoring DESTDIR.

@daltomi do you have any hints as to how to fix it? I'm not good with autoconf so I'm unable to figure out what to do here.

EDIT: I was able to fix it after asking some LLMs around which pointed me towards $datadir, see: #424.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants