Skip to content

fix: clear expire params of Contact #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yeoleobun merged 1 commit into from
Feb 4, 2026
Merged

fix: clear expire params of Contact #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/dialog/registration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use crate::{
};
use rsip::{
prelude::{HeadersExt, ToTypedHeader},
Response, SipMessage, StatusCode,
Param, Response, SipMessage, StatusCode,
};
use tracing::debug;

Expand Down Expand Up @@ -378,7 +378,7 @@ impl Registration {
// 3. Local non-loopback address (lowest priority)
// - Only used for initial registration attempt
// - Will be replaced by server-discovered address after first response
let contact = self.contact.clone().unwrap_or_else(|| {
let mut contact = self.contact.clone().unwrap_or_else(|| {
let contact_host_with_port = self
.public_address
.clone()
Expand All @@ -395,6 +395,11 @@ impl Registration {
params: vec![],
}
});

if expires.is_some() {
contact.params.retain(|p| !matches!(p, Param::Expires(_)));
}

let mut request = self.endpoint.make_request(
rsip::Method::Register,
server,
Expand Down