-
Notifications
You must be signed in to change notification settings - Fork 476
fix: record field names incorrectly emitted by genType #8087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: record field names incorrectly emitted by genType #8087
Conversation
04812de to
c4bdcd4
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cristianoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to avoid quoting in the first place instead of un-quoting later?
|
@cristianoc Codex says:
|
That's a generic laziness claim rather then: you need to change X, Y, Z. These are 23 places, not worth it. |
|
that said, fighting laziness requires resources: such as knowing when to shrink the context, make more things available, know when to push back etc So feel free to use your judgment on whether it's worth the effort and dig deeper. Or just merge as is. |
c4bdcd4 to
30171ac
Compare
|
After cutting Opus loose on attempting to unquote, it reverted the unquoting change in rescript/compiler/syntax/src/res_scanner.ml Lines 340 to 348 in ff9d6d3
it's quoted here with the comment introduced in this pr |
30171ac to
0a5644a
Compare
I managed to find the source of this with Claude's help, though I don't have enough experience with ocaml to know for sure if this is an idiomatic fix. resolves rescript-lang#8086 Signed-off-by: Rob <illusionalsagacity@users.noreply.github.com>
0a5644a to
8586107
Compare
I managed to find the source of this with Claude's help, though I don't have enough experience with ocaml to know for sure if this is an idiomatic fix.
resolves #8086