ci: fix renovate approve condition to check PR author#148
Merged
Conversation
github.actor reflects who triggered the event (e.g. a human reopening the PR), not who authored it. Use github.event.pull_request.user.login in the caller to correctly identify Renovate-authored PRs regardless of who triggers the workflow. Signed-off-by: jimisola <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect actor check in the Renovate auto-approve workflow.
Problem:
github.actorreflects who triggered the event (e.g. a human reopening a PR), not who authored the PR — so theifcondition was silently skipping on legitimate Renovate PRs.Fix: Move the condition to the caller and use
github.event.pull_request.user.loginwhich always reflects the PR author regardless of who triggered the workflow.🤖 Generated with Claude Code