fix: separate docs pointer from sync pointer to fix update --docs drift#849
Open
jyotirmya17 wants to merge 1 commit into
Open
fix: separate docs pointer from sync pointer to fix update --docs drift#849jyotirmya17 wants to merge 1 commit into
jyotirmya17 wants to merge 1 commit into
Conversation
|
✅ Health: 7.6 (unchanged) 📋 At a glance
🩹 Review priority (files here with the most recent bug-fix history — defects cluster, so review these first)
🔎 More signals (2)🔥 Hotspots touched (2)
🔗 Hidden coupling (2 files)
📊 Full report · ⭐ Star Repowise · 📥 Install bot · Last updated 2026-07-15 14:43 UTC |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #847.
What changed: Splits last_sync_commit and last_docs_commit to resolve pointer drift when running the update command with --index only.
How to test/verify:
Run an update with --index only.
Verify that last_sync_commit stays the same while last_docs_commit advances.
Unit tests have been added/updated in test_issue_847_fix.py to cover this behavior.