Skip to content

fix(server): use sync mode for webhook jobs#848

Open
Sanjays2402 wants to merge 1 commit into
repowise-dev:mainfrom
Sanjays2402:fix/webhook-sync-mode
Open

fix(server): use sync mode for webhook jobs#848
Sanjays2402 wants to merge 1 commit into
repowise-dev:mainfrom
Sanjays2402:fix/webhook-sync-mode

Conversation

@Sanjays2402

Copy link
Copy Markdown

Summary

  • Enqueue GitHub and GitLab pushes as sync jobs so the executor runs incremental page regeneration instead of treating incremental as an unknown mode.
  • Cover both webhook routes with regression tests that inspect the persisted job configuration.

Related Issues

Closes #837

Test Plan

  • Tests pass (pytest) — pytest tests/unit/server/test_webhooks.py (7 passed)
  • Lint passes (ruff check .) — scoped checks pass; the touched source file has a pre-existing import-order finding
  • Web build passes (npm run build) (if frontend changes) — not applicable

Checklist

  • My code follows the project's code style
  • I have added tests for new functionality
  • All existing tests still pass — focused server tests pass; the full suite was not run
  • I have updated documentation if needed — no documentation change is needed

Webhook jobs used an unsupported incremental mode, so the executor skipped documentation regeneration while still advancing the sync baseline. Enqueue GitHub and GitLab pushes as sync jobs and cover both routes with regression tests.
@repowise-bot

repowise-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

✅ Health: 7.6 (unchanged)

📋 At a glance
1 file changed health · 1 hotspot touched · 1 new finding introduced · 5 co-change pairs left out · 1 file with recent fix history · 1 dead-code finding.

Files & modules (2)
  • packages (1 file)
    • .../routers/webhooks.py
  • tests (1 file)
    • .../server/test_webhooks.py

🩹 Review priority (files here with the most recent bug-fix history — defects cluster, so review these first)

File Score Δ Why
.../server/test_webhooks.py 10.0 → 9.8 ▼ -0.2 🔻 introduced primitive obsession

💡 .../server/test_webhooks.py: Introduce a parameter object. Group the related primitives passed in here into a dataclass so the type names tell the story and adding another field doesn't break every caller.

🔎 More signals (3)

🔥 Hotspot touched (1)

  • .../server/test_webhooks.py — 0 commits/90d, 1 dependents · primary owner: Raghav Chamadiya (100%)

🔗 Hidden coupling (1 file)

  • .../routers/webhooks.py co-changes with these files (not in this PR):
    • .gitignore (2× — 🟢 routine)
    • .../cli/helpers.py (2× — 🟢 routine)
    • .../persistence/__init__.py (2× — 🟢 routine)
    • .../server/app.py (2× — 🟢 routine)
    • .../server/deps.py (2× — 🟢 routine)

💀 Dead code (1 finding)

  • 💀 .../routers/webhooks.py (file-level) (confidence 0.80)

📊 Full report · ⭐ Star Repowise · 📥 Install bot · Last updated 2026-07-15 10:00 UTC
Silence on a single PR with [skip repowise] in the title · Per-repo toggle on repowise.dev/settings?tab=bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webhook jobs silently skip incremental documentation regeneration

1 participant