Skip to content

EPMRPP-115983 || login page redesign core form password field eye change#304

Merged
VaheSamsonyan merged 3 commits into
developfrom
feature/EPMRPP-115983-Login-Page-redesign-Core-form---password-field-eye-change
Jun 16, 2026
Merged

EPMRPP-115983 || login page redesign core form password field eye change#304
VaheSamsonyan merged 3 commits into
developfrom
feature/EPMRPP-115983-Login-Page-redesign-Core-form---password-field-eye-change

Conversation

@VaheSamsonyan

@VaheSamsonyan VaheSamsonyan commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Visuals

passwordIconsmp4.mp4

Description

changed password Icons

Summary by CodeRabbit

  • Style
    • Updated password visibility toggle icons in text input fields with new icon designs for improved visual consistency.
  • Tests
    • Adjusted icon-related mocks in field text component tests to keep existing icon behavior intact while controlling the clear icon rendering.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 37e67a9d-7b60-4c7a-9aa2-9da1160cd610

📥 Commits

Reviewing files that changed from the base of the PR and between 3637adb and 43a30af.

📒 Files selected for processing (1)
  • src/components/fieldText/fieldText.test.tsx

Walkthrough

Two new SVG icon exports (ClosedEyeIcon, OpenedEyeIcon) are added to the icons barrel index. fieldText.tsx updates its imports to use these renamed icons and changes the BaseIconButton import source, replacing the previous CloseEyeIcon/OpenEyeIcon names in the password visibility toggle render. The fieldText test mock is updated to an async factory that imports the real icons module and re-exports all of it while mocking ClearIcon.

Changes

Eye Icon Rename

Layer / File(s) Summary
New ClosedEyeIcon and OpenedEyeIcon exports
src/components/icons/index.ts
Adds ClosedEyeIcon (from ./svg/closedEye.svg) and OpenedEyeIcon (from ./svg/openedEye.svg) as named re-exports in the icons barrel.
fieldText.tsx import, render update, and test mock
src/components/fieldText/fieldText.tsx, src/components/fieldText/fieldText.test.tsx
Replaces CloseEyeIcon/OpenEyeIcon with ClosedEyeIcon/OpenedEyeIcon in imports and updates the BaseIconButton import source; the password visibility toggle now renders OpenedEyeIcon when visible and ClosedEyeIcon otherwise. The test mock is updated from synchronous to async, importing the real icons module and re-exporting all exports while overriding ClearIcon with a test double.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit peeked with one bright eye,
The icons renamed beneath the sky.
CloseEye and OpenEye — old names, farewell!
ClosedEye, OpenedEye now cast their spell.
The password toggle blinks just right,
A tidy rename, pixel-perfect sight! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is partially related to the main changes - it mentions 'password field eye change' which aligns with the icon replacements in fieldText.tsx, but includes redundant information (issue ID, 'login page redesign core form') that adds noise without clarity about the specific technical change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/EPMRPP-115983-Login-Page-redesign-Core-form---password-field-eye-change

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@VaheSamsonyan VaheSamsonyan merged commit 7704aee into develop Jun 16, 2026
2 checks passed
@VaheSamsonyan VaheSamsonyan deleted the feature/EPMRPP-115983-Login-Page-redesign-Core-form---password-field-eye-change branch June 16, 2026 06:41
github-actions Bot pushed a commit that referenced this pull request Jun 16, 2026
…nge (#304)

* changed new closed eye icon

* changed new opened eye icon

* updated the fieldText test

---------

Co-authored-by: vahesamsonyan <vahe_samsonyan@epam.com> 7704aee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants