Isolate shared MCP state in the Agent Mode handoff test - #501
Open
morluto wants to merge 3 commits into
Open
Conversation
morluto
marked this pull request as ready for review
July 11, 2026 06:28
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Agent Mode handoff regression test mutates shared MCP, window, and global application state. Without ownership covering the complete setup, assertion, and cleanup lifecycle, another concurrently scheduled suite could observe transient state or begin before cleanup finishes.
Approach
Hold the existing shared-server lease for the test's entire lifecycle and finish deterministic window cleanup before releasing it. Also classify the suite with the canonical serial-group tag so the runner and the test agree about the shared resource.
Changes
MCPSharedServerTestLeaseacross setup, assertions, and teardown.#if DEBUG.mcp_shared_serverserial-group tag.This does not make the suite parallel-eligible. It makes its required serialization explicit and its cleanup deterministic.
Validation
Repository guardrails, suite-plan classification, and contribution preflights passed. Focused XCTest execution and ledger verification remain macOS CI checks.