fix(release): put the v1 line back on changesets/action@v1 - #50
Merged
Conversation
Renovate walked `main` on to `changesets/action` v2, v2.1.0 and v2.1.1 while `main` is the v1 line, so both release workflows ran action v2 against v1 input names and every release on the line aborted with "The following inputs have been renamed". The oidc variant's own header still says it pairs action v1 with CLI v2. Restore both to `@v1`, and disable major updates for `changesets/action` in renovate.json — that major is the v1/v2 line boundary, moved by cutting a line, never by a bump. Also close the internal-ref gap the README left open: the workflows' `setup-playwright` refs move from `@main` to `@v1`, so a consumer pinned at `@v1` gets the composite action from `v1` too. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the break behind #43-style failures now showing up in
repobuddy/visual-testing.What broke
mainis the v1 line:pnpm-release-changeset.ymlandpnpm-release-changeset-oidc.ymlpairchangesets/action@v1with consumers on@changesets/cliv2. Renovate auto-merged three bumps onto it anyway —v2,v2.1.0,v2.1.1— leaving action v2 running against v1 input names. Every release on the line aborts:The oidc variant still carries a header comment saying it pairs action v1 with CLI v2, which is how obvious the regression is.
What this does
changesets/action@v1..github/renovate.jsondisables major updates forchangesets/action. That major is the v1/v2 line boundary — it moves by cutting a new line alongside consumers' CLI major, never by a dependency bump. The Mergifyhead~=^(?!major-)guard does not match Renovate branch names and so never held it back; that defect is still open separately, this just takes the one dependency that cannot survive it out of Renovate's hands.repobuddy/visual-testingmoves to@changesets/cli^3.0.0/@v2(see ci: pin the shared workflows to @v2, and finish the changesets v3 move visual-testing#844).setup-playwrightrefs move from@mainto@v1, so a consumer pinned at@v1no longer picks the composite action offmain. The README said to do this oncev1.0.0was cut, and it has been.After merging
Re-point the moving alias, or none of this reaches consumers:
Not in this PR
v2.xis onchangesets/action@v2.0.0and its internalsetup-playwrightrefs still say@main. Both want the same treatment on that branch (@v2.1.1and@v2) plus av2.0.1release. Nothing is broken there today, so it is a separate change.🤖 Generated with Claude Code