Repository navigation
Finish the Chinese terminology and register fixes: 注解 everywhere, seven phrases rewritten - #26
Merged
Merged
Conversation
Content finding B23 asked for one Chinese term for annotation. The chapter
PRs changed most uses, but five that mean a type annotation were left:
- chapter 03: two comments in the assertion-function sample and the
sentence after it;
- chapter 04: the sentence on rewriting every JS file before TypeScript
could type it, which now reads 才能为它们写出类型 to match the English
("before TypeScript could type it");
- chapter 06: a quiz explanation.
The one remaining 标注 is a stylesheet comment in app/home.css, where it
means "marks", not a type annotation.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Deployment failed for project tser with the following error: Learn More: https://vercel.com/renrenmimis-projects?upgradeToPro=build-rate-limit |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
renrenmimi
added a commit
that referenced
this pull request
Oct 10, 2026
#26 changes the last five uses of 标注 to 注解, so the changelog's claim of one term per concept now holds; it is listed with the chapter PRs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fix record listed seven informal phrases that the chapter PRs did not reach (content finding B22). Two sit in sentences this PR already edits. Each now reads as written prose; the English is unchanged: - prologue: 反复捣乱 -> 反复干扰理解; - chapter 03: 撞上 -> 违反; - chapter 04: 没人会这么干 -> 这在现实中行不通; - chapter 10: 会踩的那个坑 -> 容易落入的陷阱; 好几年没人敢改 ... 你干活的 时候,系统不能停 -> 多年来没有人敢修改 ... 迁移期间,系统必须照常运行; 债还清了也不吭声 -> 即使底下的错误已经修好,它也不会提示; - finale: 项目扛得住时 -> 项目条件成熟时. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
renrenmimi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finishes two content findings from the 2026-10-09 audit that the chapter PRs (#17–#22) left partly done:
Both apply to Chinese only; the English is unchanged. CLAUDE.md states the terms since #23.
Changes
B23: five places that said 标注 for a type annotation
app/narrowing/page.tsx): the two comments in the assertion-function sample, and the sentence that follows them.app/structural/page.tsx): 「才能被 TypeScript 标注」 becomes 「TypeScript 才能为它们写出类型」. This follows the English ("before TypeScript could type it") and the next sentence, which says TypeScript 描述 JavaScript.lib/utility-data.tsx): a quiz explanation.The one 标注 left under
app/andlib/is a stylesheet comment inapp/home.css. There it means "marks", not a type annotation.B22: seven colloquial phrases the fix record listed as left over
Verification
git grep 标注 -- app libfinds only the stylesheet comment. None of the seven phrases is left anywhere underapp/orlib/.test/zh-copy-spacing.test.ts;npx tsc --noEmit --incremental false;npm test(14 files, 89 tests).🤖 Generated with Claude Code