Repository navigation
Bring the README and its screenshots up to date after the audit fixes - #25
Merged
Merged
Conversation
- Describe the compiler lab's loading and failure banner and its Playground link, the tests and CI, the untracked compiler copies, the per-chapter server layouts and the self-hosted fonts, and add the language toggle, keyboard and contrast notes. - Re-take the three screenshots the way the originals were taken: home and generics at 1280x800 in Chinese with the dark theme, saved at 1000x625; the compiler lab at 1440x950 with a device scale factor of 1.5, in English with the dark theme, on the first lab of chapter 01 with the three edits from #8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Deployment failed for project tser with the following error: Learn More: https://vercel.com/renrenmimis-projects?upgradeToPro=build-rate-limit |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README and its three screenshots still showed the course as it was before #9–#23. This PR updates the text to match
master(f7adc58) and re-takes the screenshots the same way as the originals.Changes
npm testruns Vitest. CI runs the typecheck, the tests, the build andcheck:bundleon every push tomasterand on every pull request. The compiler copies thatprepare-tslabwrites underpublic/tslab/are not tracked (Free the lab editor's keyboard, keep code readable when the compiler fails, and localise presets #14).layout.tsxsets each chapter's title and description (Restore settings after a client re-render, title every page, and self-host the fonts #10). The fonts are self-hosted fromapp/fonts/, and English pages download no Chinese font (Restore settings after a client re-render, title every page, and self-host the fonts #10).docs/home.jpg,docs/generics.jpg: re-taken with the method from 42baf47, which describes them as "plain browser captures at 1280x800, compressed". They use a 1280×800 viewport at device scale factor 1, Chinese, dark theme and the top of the page, and are saved as 1000×625 JPEG like the originals.docs/compiler-lab.jpg: re-taken as in docs: show the compiler lab in the README #8./types, with the three edits from docs: show the compiler lab in the README #8.TS2322,TS2345andTS7006, thetsc 5.9.3badge, theDeclaration .d.tstab, and the status lineedited · TS2322, TS2345 +1.Verification
f7adc58(next start), taken in headless Chrome 155 through playwright-core 1.62.1. In the lab shot the codes were read from the page before capture, and the editor was blurred so that no focus ring shows.master:.github/workflows/ci.yml;package.jsonscripts;.gitignore;app/*/layout.tsx;app/fonts/;lib/tslab.tsx;🤖 Generated with Claude Code