Repository navigation
Match chapter 05's preset text to the compiler, align its examples, and tidy chapter 04 - #19
Merged
Merged
Conversation
JSX trims each line of a text block and joins the lines with one space.
The Chinese copy is wrapped across source lines throughout the course, so
it rendered with spaces between Chinese characters and around full-width
punctuation: 1,572 of them in 36 files.
- 1,548 line breaks are joined by a script that walks the TypeScript
syntax tree and touches only JSX text and JSX attribute strings, never
code samples, template literals or comments. Breaks next to Latin
letters, digits, expressions, "——" or operators keep their space.
- 24 more spaces go: 20 after full-width punctuation, 3 between Chinese
text and a tag whose text is Chinese, and one {" "} between a
full-width mark and Chinese text.
- test/zh-copy-spacing.test.ts, the check DataData and AlgoAlgo use,
scans every TSX file and fails on any new stray space; CLAUDE.md states
the rule.
Apart from the one {" "}, the diff changes nothing but whitespace. The
text every edited file renders differs from master only by deleted
spaces, each next to Chinese text, so the English copy is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…idy chapter 04 Chapter 05 - "Drop the constraint" only removes longest's constraint: the text now says the longest(10, 100) error disappears, TS2339 appears twice inside longest, and getProp's error stays, which is what the lab shows. - The opening example names the three array types the code uses (string[], number[], Order[]) in both languages; the Chinese erasure note says type arguments are resolved during compilation, not "before compilation", as the English says. Chapter 04 - Copy only: the "traps" headings and the colloquial verbs become formal Chinese. Both chapters - Formal Chinese register (先痛一下, 姿势, 掰直, 想岔, 糊, 坑, 一声没吭, 撞上), quiz titles 本章测验 / Chapter quiz, and aria-pressed on the segmented buttons of the compatibility, freshness and generic-call visuals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Deployment failed for project tser with the following error: Learn More: https://vercel.com/renrenmimis-projects?upgradeToPro=build-rate-limit |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branches from #9 (commit
2148ad8), so it can be merged before or after it, and independently of #10–#18.It touches chapter 04 (
app/structural/page.tsx,viz.tsx) and chapter 05 (app/generics/page.tsx,viz.tsx,lib/generics-data.tsx). It does not touch the four structural presets, which #14 owns.Summary
Fixes from the 2026-10-09 content audit (
04-TSer-内容.md):longest's constraint is removed.longest, TS2339 appears twice.getProp(menu, "topping")'s TS2345 stays.string[],number[]andOrder[].Changes
aria-pressedon theseg-btnbuttons.Verification
npx tsc --noEmit --incremental false: clean.npm test: 6 files, 38 tests pass, includingzh-copy-spacing.npm run build: succeeds.8:9 TS2345and17:15 TS2345.2:12 TS2339,2:24 TS2339and15:15 TS2345.next start, in both languages: the new text is on both pages, none of the old phrases remain, and there are 0 console errors.🤖 Generated with Claude Code