Skip to content

Patch the undici, Next.js, sharp and source-map-js advisories - #16

Merged
renrenmimi merged 2 commits into
masterfrom
chore/dependency-advisories
Oct 10, 2026
Merged

renrenmimi merged 2 commits into
masterfrom
chore/dependency-advisories

Conversation

@renrenmimi

Copy link
Copy Markdown
Owner

Branches from #9 (commit 2148ad8). It changes only package.json and package-lock.json, so it is independent of #10–#15.

Summary

  • Open Dependabot alert Add a branded application favicon #2 (GHSA-w293-vg96-wgc3, high): undici 7.29.0 can bypass TLS certificate validation in BalancedPool. undici is a dev dependency, pulled in by jsdom.
  • Reported by npm audit, not yet raised by Dependabot:
    • next 15.5.25: SSG/ISR cache poisoning, GHSA-4jqv-mc3x-m676 and GHSA-mcj8-r9mp-w47p (moderate).
    • sharp 0.35.4: librsvg, GHSA-wq5f-xc86-pv6w (high).
    • source-map-js 1.2.1: event-loop DoS, GHSA-68fv-2mgg-jv7q (high).

Changes

  • package.json
    • next is ^15.5.27.
    • The overrides are sharp ^0.35.5, source-map-js ^1.2.2 and undici ^7.29.1. The postcss override is unchanged.
  • package-lock.json: next 15.5.27, sharp 0.35.5, source-map-js 1.2.2 and undici 7.30.0. Only these packages and their platform sub-packages change.

Verification

  • npm audit: 0 vulnerabilities.
  • npx tsc --noEmit --incremental false: clean.
  • npm test: 6 files, 38 tests pass.
  • npm run build with Next.js 15.5.27 succeeds.
  • Headless Chrome against a local next start: all 12 pages return 200 with 0 console errors, and the first compiler lab loads tsc 5.9.3.

🤖 Generated with Claude Code

renrenmimi and others added 2 commits October 9, 2026 16:07
JSX trims each line of a text block and joins the lines with one space.
The Chinese copy is wrapped across source lines throughout the course, so
it rendered with spaces between Chinese characters and around full-width
punctuation: 1,572 of them in 36 files.

- 1,548 line breaks are joined by a script that walks the TypeScript
  syntax tree and touches only JSX text and JSX attribute strings, never
  code samples, template literals or comments. Breaks next to Latin
  letters, digits, expressions, "——" or operators keep their space.
- 24 more spaces go: 20 after full-width punctuation, 3 between Chinese
  text and a tag whose text is Chinese, and one {" "} between a
  full-width mark and Chinese text.
- test/zh-copy-spacing.test.ts, the check DataData and AlgoAlgo use,
  scans every TSX file and fails on any new stray space; CLAUDE.md states
  the rule.

Apart from the one {" "}, the diff changes nothing but whitespace. The
text every edited file renders differs from master only by deleted
spaces, each next to Chinese text, so the English copy is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- undici 7.29.0 → 7.30.0 (GHSA-w293-vg96-wgc3, high: TLS certificate validation bypass in
  BalancedPool), the open Dependabot alert; it comes in through jsdom, so it is pinned with an
  override.
- next 15.5.25 → 15.5.27 (GHSA-4jqv-mc3x-m676, GHSA-mcj8-r9mp-w47p: SSG/ISR cache poisoning),
  sharp 0.35.4 → 0.35.5 (GHSA-wq5f-xc86-pv6w, librsvg) and source-map-js 1.2.1 → 1.2.2
  (GHSA-68fv-2mgg-jv7q), which npm audit reports and Dependabot has not raised yet.
- The declared ranges and overrides now start at the patched versions, so a fresh install
  cannot fall back below them. npm audit: 0 vulnerabilities.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 10, 2026 05:38
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@vercel

vercel Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tser Error Error Oct 10, 2026 5:38am UTC

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@renrenmimi
renrenmimi merged commit 9fb84d0 into master Oct 10, 2026
2 of 3 checks passed
@renrenmimi
renrenmimi deleted the chore/dependency-advisories branch October 10, 2026 06:22

This branch had an error being deployed

1 failed deployment
Preview — 4c80440e Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants