Repository navigation
Scenario: a meetup cancelled while people join, a code revoked while they redeem - #320
Conversation
…they redeem - meetup: a second meetup, with room for everyone, is cancelled while they are joining. Nobody gets in after the cancel, and the roster and its count agree. On the emulators, everyone on the roster is told it is cancelled; the test project has no onMeetupUpdated. - invitation: a second code is revoked while three people redeem it. At most one gets in, and nobody after the revoke. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2dd2bfe26c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| check("meetup: and its roster and count agree", | ||
| cancelled?.participantCount === cancelledRoster.length && !cancelledRoster.some((r) => r.id === late.uid), |
There was a problem hiding this comment.
When any concurrent join reports success but fails to create its participant document or increment the count, this check still passes as long as the remaining roster and count agree (for example, both remain at the organizer-only value of 1). joinedBefore is used only in diagnostic output, so the scenario does not enforce its stated invariant that everyone who successfully joined before cancellation is present and counted; retain the successful users and assert their UIDs are in cancelledRoster and reflected in participantCount.
Useful? React with 👍 / 👎.
Two more races in
functions/scripts/scenario-many-users.mjs.meetuponMeetupUpdated.invitationOn the test project, 200 people: both new checks pass.
The same run found joins on the full meetup told
internal(2 of 180), which the next PR fixes.🤖 Generated with Claude Code