Repository navigation
Meetups: a refused join reads in the phone's language - #319
Conversation
The server refuses a join in English sentences, one or several of a meetup's rules at once, and the app showed them as they came: a phone set to Chinese read "Meetup is full." in English. MeetupRefusal puts each sentence the server can send into the phone's language. The rules are the lines the meetup screen already shows before joining, with their translations; three refusals of the server's own are new to the catalog. A sentence it does not know is shown as the server wrote it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3382b06e93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// into the phone's language one by one. A sentence this does not know is | ||
| /// shown as the server wrote it, rather than not at all. | ||
| enum MeetupRefusal { | ||
| static func localized(_ reason: String, bundle: Bundle = .main, locale: Locale = .current) -> String { |
There was a problem hiding this comment.
When PetNote is set to Chinese independently in Settings while the device locale remains English, the default .current selects English even though Bundle.main.preferredLocalizations selects Chinese, so these refusals still disagree with the rest of the interface. The repository already accounts for this distinction in PostAge.interfaceLocale; derive the default locale from the bundle (or let normal bundle localization choose it). The new tests miss this production path because they always inject zh-Hans explicitly.
Useful? React with 👍 / 👎.
The server refuses a join in English sentences, one or several of a meetup's rules at once. The app showed them as they came, so a phone set to Chinese read "Meetup is full." in English. The 200-person meetup race in the scenario script brought this up.
MeetupRefusalputs each sentence the server can send into the phone's language:In English nothing changes.
Tests. Five new unit tests run against the built app's Chinese bundle:
The full unit suite passes on the simulator: 1077 tests in 94 suites. That includes the check that every catalog translation reached the built app.
🤖 Generated with Claude Code