Repository navigation
fix(release): declare the repository for npm provenance - #31
Merged
Merged
Conversation
The first automated publish of the Studio 0.2.0 packages was rejected by npm with E422: provenance verification requires package.json repository.url to match the GitHub repository, and neither package declared it. Trusted Publishing itself succeeded; nothing was published. Declare the repository in both packages, and have the release workflow set it on the runner copy before packing so versions tagged before this change (v3.4.0) can still be published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first automated publish of the Studio
0.2.0packages (run #1) was rejected by npm:Trusted Publishing itself worked: npm accepted the workflow identity and signed the provenance. Verification then failed because neither package declares
repository. Nothing was published; npm still shows0.1.2and0.1.1.Changes
package.jsonfiles now declarerepository:url:https://github.com/rendis/stateprodirectory: the package's path in the repoGITHUB_REPOSITORY. This is needed because the npm job publishes what is tagged, and thev3.4.0tag predates the field. The tag can still be published without cutting a new release.Validation
package.jsonfiles withoutrepository) and ran the workflow's pack loop with pnpm 10.11.0:repository.urlanddirectory.@rendis/statepro-studio-react0.2.0.npm publish --dry-runaccepts both tarballs.actionlintreports no issues, andpnpm install --frozen-lockfileleaves the lockfile unchanged.After merge, the push to
mainreruns the release workflow. It planstarget=npmagain and publishes both0.2.0packages fromv3.4.0.