Repository navigation
Support texture readback through copyTextureRegion - #114
Merged
Merged
Conversation
squidbus
reviewed
Sep 20, 2026
squidbus
left a comment
squidbus
left a comment
Contributor
There was a problem hiding this comment.
I can't vouch for the D3D12 but the others look okay to me.
dcvz
requested changes
Oct 12, 2026
dcvz
left a comment
dcvz
left a comment
Contributor
There was a problem hiding this comment.
One thing I noticed is that it ignores dstX/Y/Z and sizes the copy from the footprint instead of srcBox which is not how D3D12 does it.
dcvz
approved these changes
Oct 16, 2026
DarioSamo
self-requested a review
October 16, 2026 19:01
DarioSamo
reviewed
Oct 21, 2026
DarioSamo
requested changes
Oct 21, 2026
DarioSamo
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly adds support for copyTextureRegion calls in the other direction.