Repository navigation
Module pages: Enter in a password field does what its button does - #141
Merged
Merged
Conversation
On the XIAO page the Firmware tab's password (Update or restart card) and
the Module network password are not in a form, so Enter did nothing there.
The same on the sprayer and seed drill pages for the password at the end of
Network settings.
- XIAO: Enter in the Firmware password runs the action that asked for it
("Type the XIAO network password": Install from GitHub, the module's
firmware, Go back), else Install with a .bin chosen, else Install from
GitHub; never Restart. Enter in the Module network password changes the
subnet. Every action still asks first. Save and the subnet now say when
the password is missing instead of asking and failing.
- Sprayer 0.10.7, seed drill 0.2.8: Enter in the Save card's password saves.
- All four pages: in the question box a held Enter answers nothing (on the
Teensy page a held Enter on Restart Teensy opened the question and
confirmed it), and Enter with no password typed does nothing.
- An empty field or a held key never does anything, as in AgOpenWeb's
new-field name box.
- Simulator check: Enter in the XIAO page's password fields, in the
sprayer's, and a held Enter on the Teensy page; they fail on the old pages.
- XIAO C3 / S3 .bin and _USB.bin, sprayer and seed drill .bin and
.merged.bin rebuilt (esp32 3.3.12, 13 Nov 16:12-16:14). The Teensy .hex is
not rebuilt here (the cloud cannot compile it): the CI check compiles it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VKEBDGoRdpfCQJfu3FxP8b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Renato · project thread
What changes
On the XIAO page, pressing Enter in the Firmware tab's password field did nothing: that field (and the Module network one) is not in a form, so the browser had nothing to submit. The same on the sprayer and seed drill pages for the password at the end of Network settings.
Now Enter in a password field does what its button does, and the page's question still comes first:
.binchosen, else Install from GitHub. Never Restart. With nothing to install it says so.An empty field or a held key never does anything, the same rule as AgOpenWeb's new-field name box.
Files
xPage.h,zWebPage.h,sPage.h,dPage.h..binand_USB.bin,Sprayer_ESP32.ino.bin/.merged.bin,Seeder_ESP32.ino.bin/.merged.bin..hexis not rebuilt: the cloud cannot compile it. The "Teensy firmware" check compiles it; build and upload the.hexas usual when convenient. The Teensy change is only the held-Enter guard.smoke-test.js): Enter in the XIAO page's password fields (empty, after Install from GitHub asked, held with a.binchosen), in the sprayer's Save password and its empty password box, and a held Enter on Restart Teensy. These checks fail on the old pages.How to test
Generated by Claude Code