Skip to content

Module pages: Enter in a password field does what its button does - #141

Merged
renatorgr merged 1 commit into
mainfrom
module-pages-enter-password
Nov 13, 2026
Merged

renatorgr merged 1 commit into
mainfrom
module-pages-enter-password

Conversation

@renatorgr

Copy link
Copy Markdown
Owner

Requested by Renato · project thread

What changes

On the XIAO page, pressing Enter in the Firmware tab's password field did nothing: that field (and the Module network one) is not in a form, so the browser had nothing to submit. The same on the sprayer and seed drill pages for the password at the end of Network settings.

Now Enter in a password field does what its button does, and the page's question still comes first:

  • XIAO, Firmware tab (Update or restart password): the action that asked for the password ("Type the XIAO network password": Install from GitHub, the module's firmware, Go back), else Install with a .bin chosen, else Install from GitHub. Never Restart. With nothing to install it says so.
  • XIAO, WiFi tab: Enter in the Module network password changes the subnet. Save and restart the XIAO and the subnet now say when the password is missing, instead of asking and then failing.
  • Sprayer 0.10.7, seed drill 0.2.8: Enter in the Network settings password saves.
  • All four pages (Teensy too), the question box: a held Enter answers nothing, and Enter with no password typed does nothing. Before, a held Enter on Restart Teensy opened the question and confirmed it at once (seen in the simulator check).

An empty field or a held key never does anything, the same rule as AgOpenWeb's new-field name box.

Files

  • Pages: xPage.h, zWebPage.h, sPage.h, dPage.h.
  • Rebuilt with esp32 3.3.12 (13 Nov 16:12-16:14): XIAO C3 / S3 .bin and _USB.bin, Sprayer_ESP32.ino.bin / .merged.bin, Seeder_ESP32.ino.bin / .merged.bin.
  • The Teensy .hex is not rebuilt: the cloud cannot compile it. The "Teensy firmware" check compiles it; build and upload the .hex as usual when convenient. The Teensy change is only the held-Enter guard.
  • Simulator check (smoke-test.js): Enter in the XIAO page's password fields (empty, after Install from GitHub asked, held with a .bin chosen), in the sprayer's Save password and its empty password box, and a held Enter on Restart Teensy. These checks fail on the old pages.
  • READMEs and changelogs.

How to test

  1. Wait for All checks have passed, merge.
  2. XIAO page → Firmware → Install from GitHub. It asks for the password: type it, press Enter. The question "Install … from GitHub on the XIAO?" opens; Enter again (or OK) installs.
  3. Sprayer / seed drill page → Network settings → type the password at the end → Enter: "Save and restart the module?" opens (Cancel if you do not want the restart).

Generated by Claude Code

On the XIAO page the Firmware tab's password (Update or restart card) and
the Module network password are not in a form, so Enter did nothing there.
The same on the sprayer and seed drill pages for the password at the end of
Network settings.

- XIAO: Enter in the Firmware password runs the action that asked for it
  ("Type the XIAO network password": Install from GitHub, the module's
  firmware, Go back), else Install with a .bin chosen, else Install from
  GitHub; never Restart. Enter in the Module network password changes the
  subnet. Every action still asks first. Save and the subnet now say when
  the password is missing instead of asking and failing.
- Sprayer 0.10.7, seed drill 0.2.8: Enter in the Save card's password saves.
- All four pages: in the question box a held Enter answers nothing (on the
  Teensy page a held Enter on Restart Teensy opened the question and
  confirmed it), and Enter with no password typed does nothing.
- An empty field or a held key never does anything, as in AgOpenWeb's
  new-field name box.
- Simulator check: Enter in the XIAO page's password fields, in the
  sprayer's, and a held Enter on the Teensy page; they fail on the old pages.
- XIAO C3 / S3 .bin and _USB.bin, sprayer and seed drill .bin and
  .merged.bin rebuilt (esp32 3.3.12, 13 Nov 16:12-16:14). The Teensy .hex is
  not rebuilt here (the cloud cannot compile it): the CI check compiles it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VKEBDGoRdpfCQJfu3FxP8b
@renatorgr renatorgr self-assigned this Nov 13, 2026
@renatorgr
renatorgr marked this pull request as ready for review November 13, 2026 16:30
@renatorgr
renatorgr merged commit f32e192 into main Nov 13, 2026
5 checks passed
@renatorgr
renatorgr deleted the module-pages-enter-password branch November 13, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants