Repository navigation
Module pages ask in their own box, not browser pop-ups - #127
Merged
Merged
Conversation
…rompt() Inside an AgOpenWeb web card the page's frame has no allow-modals (official Docs/ADD_ON_CARDS.md): confirm() returns false and prompt() null without showing anything, so Save and restart, Install, Restart, the TM171 and receiver actions and the settings defaults did nothing there. The Teensy, XIAO, sprayer and seed drill pages now ask with an in-page box (ask / askText) and their handlers await the answer; the wording is unchanged. Sprayer 0.10.5 and seed drill 0.2.6 with their .bin rebuilt, the XIAO C3 / S3 .bin rebuilt (esp32 core 3.3.12); the Teensy .hex is left to the IDE. The simulator check fails on any browser dialog and opens the sprayer and Teensy pages inside a frame with the card's sandbox, where the box must open, fit 480 x 320 and answer. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VKEBDGEvHbKp3vpaXLUKir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Renato · project thread
What changes
Inside an AgOpenWeb web card a module page runs in a frame without
allow-modals(officialDocs/ADD_ON_CARDS.md), so the browser'sconfirm()andprompt()answer "no" at once without showing anything. Every button that asked a question first did nothing in a card: Save and restart (Wi-Fi), Install (a file or GitHub), Restart, the TM171 write and calibrations, the receiver set-up load and baud rate, the UM982 risky commands, the settings Defaults, Go back. Measured in the simulator inside a frame with the card's sandbox:confirmgives false,promptgives null.The four pages (Teensy
zWebPage.h, XIAOxPage.h, sprayersPage.h, seed drilldPage.h) now ask with their own box:ask(text)for OK / Cancel,askText(text)for the Wi-Fi password. Same wording as before, dark or light with the page, fits a 480 × 320 card, buttons 44 px high, Enter and Escape work, a tap outside cancels. The handlers behind those buttons areasyncand wait for the answer; nothing else in the pages changes. 34 places: Teensy 18, XIAO 8, sprayer 3 + the password, seed drill 3 + the password..ino.binand.merged.binrecompiled here (arduino-cli, esp32 core 3.3.12); the other board of each program compiles too..binand_USB.binrecompiled here, same core.zWebPage.hchanges (the page text). The.hexis not rebuilt here: the Teensy toolchain cannot be installed in Claude's cloud sessions. The "Teensy firmware" check compiles it on this pull request; Renato exports the.hexfrom the Arduino IDE before or after merging, as usual.smoke-test.js): a browser pop-up on any page now fails the check; the sprayer and Teensy pages are also opened inside a frame with an AgOpenWeb web card's sandbox, where the box must open, fit the card and answer (Cancel and Escape do nothing, OK and Enter go on). Passes locally.How to test
.hex): Firmware → Restart Teensy, IMU → Calibrate, Settings → Defaults: the box opens; OK goes on, Cancel does not.Checks run here:
python3 .github/scripts/check_shared_blocks.pyOK (14 blocks),python3 .github/scripts/check_changelog.pyOK,node --checkon each page's script,python3 Firmware/simulator/build.py _site && node Firmware/simulator/smoke-test.js _sitegives "Simulator pages OK".Generated by Claude Code