Repository navigation
Boundary list: Size all gives every tree circle one diameter - #231
Merged
Merged
Conversation
… box A tester put every tree down as a 10 m circle, then found the crowns are pruned so the implement passes under all but the trunk's 1-2 m. Each circle could only be changed one at a time. "Size all", beside the diameter box, gives every circle up to a tree's size (ObstacleCircle.MaxRoundAllDiameter, 10 m, as Round all) the diameter in the box, round its own centre, after asking. A bigger circle (a pond, a clump made round) keeps its size and drawn obstacles are left as drawn. The diameter is a tree's too, at most 10 m, so the trees stay within reach of the next change. The four circle tools move to a row of their own under the box and Size all. Host: boundary.circle.diameterAll|d -> RemoteSetObstacleCirclesDiameter. Tests: ObstacleCircleTests (trees resized and a 17 m circle kept; over 10 m, no circles or a bad diameter change nothing). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VKEBDFmQpFVsahedjtN2AZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Renato · project thread
What changed
A tester put every tree down as a 10 m circle, then found the crowns are pruned so the implement passes under all but the trunk's 1-2 m. A circle's diameter could only be changed one at a time (select it, type the diameter), and the field has about 50 of them.
The boundary list's circle bar gets Size all, beside the diameter box: every circle up to a tree's size (
ObstacleCircle.MaxRoundAllDiameter, 10 m, the same limit as Round all) gets the diameter in the box, round its own centre, after a confirmation that says how many. A bigger circle (a pond, a clump made round) keeps its size, and drawn obstacles are left as drawn. The diameter given is a tree's too, at most 10 m, so the trees stay within reach of the next change. The four circle tools (+ Circles, Move, Round, Round all) move to a row of their own under the box and Size all: the bar did not fit five buttons in the 500 px menu.boundary.circle.diameterAll|d→MainViewModel.RemoteSetObstacleCirclesDiameter(saved with the field like the other circle edits).js/hud-tools.js,index.html, one CSS rule;en.jsonregenerated.Tests (
ObstacleCircleTests):Related issue
From the same day's simulator report on going round trees with a front boom (#230).
Pre-submit checklist
dotnet buildsucceeds with no errorsdotnet testpasses:ObstacleCircleTests(10 passed); the full suite runs in CIScreenshots
Before/after picture given in the project thread (the confirmation, then the five circles at 3 m).
Generated by Claude Code