Skip to content

Boundary list: Size all gives every tree circle one diameter - #231

Merged
renatorgr merged 1 commit into
pulverizadorfrom
feat/circles-one-diameter
Nov 14, 2026
Merged

renatorgr merged 1 commit into
pulverizadorfrom
feat/circles-one-diameter

Conversation

@renatorgr

Copy link
Copy Markdown
Owner

Requested by Renato · project thread

What changed

A tester put every tree down as a 10 m circle, then found the crowns are pruned so the implement passes under all but the trunk's 1-2 m. A circle's diameter could only be changed one at a time (select it, type the diameter), and the field has about 50 of them.

The boundary list's circle bar gets Size all, beside the diameter box: every circle up to a tree's size (ObstacleCircle.MaxRoundAllDiameter, 10 m, the same limit as Round all) gets the diameter in the box, round its own centre, after a confirmation that says how many. A bigger circle (a pond, a clump made round) keeps its size, and drawn obstacles are left as drawn. The diameter given is a tree's too, at most 10 m, so the trees stay within reach of the next change. The four circle tools (+ Circles, Move, Round, Round all) move to a row of their own under the box and Size all: the bar did not fit five buttons in the 500 px menu.

  • Host: boundary.circle.diameterAll|d → MainViewModel.RemoteSetObstacleCirclesDiameter (saved with the field like the other circle edits).
  • Client: js/hud-tools.js, index.html, one CSS rule; en.json regenerated.
  • README's obstacles line mentions it. Fork only.

Tests (ObstacleCircleTests):

  • three tree circles (10, 10, 6 m) become 3 m round their centres, a 17 m circle and the drawn obstacles are left, the list shows the new size, and a second change reaches the same trees;
  • a diameter over 10 m, a field with no circles and a diameter under 0.5 m change nothing.

Related issue

From the same day's simulator report on going round trees with a front boom (#230).

Pre-submit checklist

  • dotnet build succeeds with no errors
  • dotnet test passes: ObstacleCircleTests (10 passed); the full suite runs in CI
  • Tested on: Linux (cloud), the headless app driven by Playwright on a 1280 × 800 screen: five 10 m tree circles, box at 3 m, Size all, confirm: all five 3 m on the list and the map

Screenshots

Before/after picture given in the project thread (the confirmation, then the five circles at 3 m).


Generated by Claude Code

… box

A tester put every tree down as a 10 m circle, then found the crowns are
pruned so the implement passes under all but the trunk's 1-2 m. Each
circle could only be changed one at a time.

"Size all", beside the diameter box, gives every circle up to a tree's
size (ObstacleCircle.MaxRoundAllDiameter, 10 m, as Round all) the
diameter in the box, round its own centre, after asking. A bigger circle
(a pond, a clump made round) keeps its size and drawn obstacles are left
as drawn. The diameter is a tree's too, at most 10 m, so the trees stay
within reach of the next change. The four circle tools move to a row of
their own under the box and Size all.

Host: boundary.circle.diameterAll|d -> RemoteSetObstacleCirclesDiameter.
Tests: ObstacleCircleTests (trees resized and a 17 m circle kept; over
10 m, no circles or a bad diameter change nothing).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VKEBDFmQpFVsahedjtN2AZ
@renatorgr renatorgr self-assigned this Nov 14, 2026
@renatorgr
renatorgr marked this pull request as ready for review November 14, 2026 11:51
@renatorgr
renatorgr merged commit 48de731 into pulverizador Nov 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants