[CI] Resolve mask_ptr.c for Fulminate#537
Open
ZippeyKeys12 wants to merge 1 commit intorems-project:mainfrom
Open
[CI] Resolve mask_ptr.c for Fulminate#537ZippeyKeys12 wants to merge 1 commit intorems-project:mainfrom
mask_ptr.c for Fulminate#537ZippeyKeys12 wants to merge 1 commit intorems-project:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
mask_ptr.cis marked asBUGGYin the Fulminate CI. However, Fulminate runs fine on it.It fails because of
mainusing a stack pointer which is doesn't satisfy the stricter alignment precondition.However,
mainistrusted, so the file passes CN's CI, but fails Fulminate's.We resolve this oddity by having two files,
mask_ptr.candmask_ptr.error.c.The first uses
cn_aligned_allocto produce a pointer with the increased alignment.This allows the proof to go through for
mainas well.The second uses pointer arithmetic to create a pointer that always violates the increased alignment requirement.
Since we removed
trustedfrommain, this causes both the proof and Fulminate to fail.