Adding a switch for normalising types at elaboration time#805
Open
kmemarian wants to merge 1 commit intorems-project:masterfrom
Open
Adding a switch for normalising types at elaboration time#805kmemarian wants to merge 1 commit intorems-project:masterfrom
kmemarian wants to merge 1 commit intorems-project:masterfrom
Conversation
This switch replaces type aliases (e.g. size_t, uintptr_t) with their implementation-defined choice during the elaboration to Core. This commit enables the switch in the frontend of CN.
Collaborator
Author
|
@cp526 the CI failures are the same |
Collaborator
|
Thanks very much @kmemarian , that looks great! The missing step to fix those CI failures is probably for CN to apply the same normalisation of C-types in certain places, so that where C-type equality is required (e.g. the resource inference), it uses equality post normalisation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switch replaces type aliases (e.g. size_t, uintptr_t) with their implementation-defined choice during the elaboration to Core.
This commit enables the switch in the frontend of CN.
This should address some issues from #678, #236, #272.
@cp526 for #678 CN now gives a "Missing resource for reading" error on variables with the alias type.