tabs.ts: Loosen type of SvgGraph.svg#193
Open
SamB wants to merge 1 commit intorems-project:masterfrom
Open
Conversation
`@types/jquery` version 3.3.35 and 3.3.36 made some changes to the type of JQuery.find(), see the PRs: * DefinitelyTyped/DefinitelyTyped#43857 * DefinitelyTyped/DefinitelyTyped#44051 As a result, the following line in SvgGraph.setSVG would fail to typecheck: ```typescript this.svg = this.container.find('svg') ``` But if we change the svg property's type from `JQuery<HTMLElement>` to `JQuery<Element>`, we don't have to care about the changes: it typechecks either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@types/jqueryversion 3.3.35 and 3.3.36 made some changes to the typeof JQuery.find(), see the PRs:
[@types/jquery] Improve type for find function DefinitelyTyped/DefinitelyTyped#43857
[@types/jquery] Update generic type variable for find function DefinitelyTyped/DefinitelyTyped#44051
As a result, the following line in SvgGraph.setSVG would fail to
typecheck:
But if we change the svg property's type from
JQuery<HTMLElement>toJQuery<Element>, we don't have to care about the changes: it typecheckseither way.