refactor(test): refactor and delete redundant unit tests covered by main automation#100
Open
refactor(test): refactor and delete redundant unit tests covered by main automation#100
Conversation
962b22b to
ad247e6
Compare
Collaborator
|
I think some of those test are hard to maintain and subsumed by existing CLI-level test and #103 In general, I think unit tests need to
Any test at an entire test level should be done from the CLI as it is easier to maintain and forces use to keep in sync the whole stack. That means concretely:
Pretty printing round-trip tests are good: They mean we can reparse what was printed, however they are not really a "unit" test so we might want to move them later |
ad247e6 to
2ef6b90
Compare
tperami
reviewed
Apr 10, 2026
| (******************************************************************************) | ||
|
|
||
| (** Unit tests for Isla.Assembler. *) | ||
|
|
Collaborator
There was a problem hiding this comment.
Those tests were good, why are you removing them?
| (** Unit tests for Isla.Symbols. *) | ||
|
|
||
| open OUnit2 | ||
|
|
2ef6b90 to
c07e534
Compare
c07e534 to
8a3cecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary