Open
Conversation
882f36c to
69ef527
Compare
* Later, it will support getting SSH information Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
69ef527 to
7431c97
Compare
bstrech
requested changes
Jan 24, 2024
Contributor
bstrech
left a comment
There was a problem hiding this comment.
@Ryanf55 Thank you for the contribution! Sorry for the late review.
Some quick notes. We did make some fixes for python httpsignatureauth to bring it up to date.
You also should add to your query total and hasMore for users with more than 1000 devices. I realize I should add some more to documentation to explain how to iterate to fetch more if there are more. See https://docs.remote.it/developer-tools/api/usage#pagination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is a simple python example to get the devices, modeled after the python example here: https://docs.remote.it/developer-tools/authentication#api-request-signing
Current Issues
remote.itdocs say to use 0.1.0. I'd love to use newer if possible, but need some advise on if remoteit will support the new draft standard.blackright now. Can we enforce that in CI withpre-commitor another tool?Demo