Repository navigation
gpui: set and clear the dock icon's badge - #16
Open
Cyberistic wants to merge 2 commits into
Open
Cyberistic wants to merge 2 commits into
Cyberistic wants to merge 2 commits into
Conversation
Adds `App::create_tray`, `App::on_tray_event`, `App::keep_running`, and the `TrayOptions`, `TrayMenuItem`, `TrayEvent` and `TrayHandle` types. Tray events never reach the application from a native callback: AppKit's menu tracking, the Windows message loop and the Linux tray service only fill a channel, and the foreground task built by `App::on_tray_event` drains it with an unborrowed App. `App::keep_running` is the tray's companion: it keeps the process alive when the last window closes. macOS backs the items with an `NSStatusItem` in the menu bar, Windows with `Shell_NotifyIconW` and a hidden message window, and Linux with a StatusNotifierItem through `ksni`, which also serves the dbusmenu. `set_title` is macOS-only and `set_tooltip` maps to each platform's nearest equivalent; both are documented as no-ops where unsupported.
Adds `App::set_dock_badge`, which writes the label macOS draws on the dock icon and clears it with `None`. The platform method is a no-op by default: Windows and Linux have no badge on a taskbar or notification-area icon, so there is nothing to draw. The label lives on the dock tile, so a menu-bar-only app (`ActivationPolicy::Accessory`) has no icon to badge. The tray example gains entries that set and clear it.
Cyberistic
marked this pull request as ready for review
October 25, 2026 04:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #15
add badge number thingy to icons in mac.
tested in mac only (obv)
slop below:
App::set_dock_badge(label)writes the label macOS draws on the dock icon, andNoneclears it.Platform::set_dock_badgeis a documented no-op by default:Windows and Linux have no badge on a taskbar or notification-area icon, so there
is nothing to draw and no honest approximation to fake.
The label belongs to the dock tile (
crates/gpui_macos/src/dock.rs), so an appwithout a dock icon — a menu-bar-only app on
ActivationPolicy::Accessory— hasnowhere to show it. That is a platform constraint, documented on the method
rather than worked around by forcing a policy.
crates/gpui/examples/tray.rsgains two menu entries that set the badge to3and clear it, so the behaviour is one click away when running the tray example.