Improve recipe panel scrolling - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refines the Recipes workbench layout so the search field and tab controls remain accessible while long recipe lists scroll beneath them, and ensures the recipe list scroll position resets when switching recipe groups/subtabs.
Changes:
- Updated recipes section CSS grid/overflow rules to make only the recipe rows area scroll on desktop while preserving page-style scrolling on narrow/mobile layouts.
- Added explicit tab-selection handlers that reset the recipe list scroll position after switching panels/subtabs.
- Refactored and extended unit tests to validate the new scroll-reset behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/web/src/features/planner/workbench/planner-workbench-sections.css | Introduces desktop-only nested scrolling for recipe rows and disables section-level scrolling; restores page scrolling on narrow screens. |
| apps/web/src/features/planner/workbench/planner-recipes-section.component.ts | Adds viewChild access to the recipe list element and resets scroll on recipe group/subtab switches. |
| apps/web/src/features/planner/workbench/planner-recipes-section.component.html | Routes tab/subtab clicks through new handlers and adds #recipeList refs for scroll reset targeting. |
| apps/web/src/features/planner/workbench/planner-recipes-section.component.test.ts | Adds coverage for scroll reset and refactors test setup to support the new behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+993
to
+997
| .planner-shell .work-section--recipes .recipe-list { | ||
| min-height: 0; | ||
| padding: 0 10px 10px; | ||
| overflow: auto; | ||
| overscroll-behavior: contain; |
relyen-dev
force-pushed
the
feature/recipe-panel-row-scrolling
branch
from
June 15, 2026 14:35
66546d8 to
7988cd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
This makes the Recipes workbench easier to navigate after scrolling through long recipe lists without changing planner data, persistence, solver behavior, or exported plan formats.
Validation
npm.cmd test -- apps/web/src/features/planner/workbench/planner-recipes-section.component.test.tsnpm.cmd testnpm.cmd run build(passes with existing Angular bundle budget warning)