-
Notifications
You must be signed in to change notification settings - Fork 9
feat: let a negentropy reconciliation say which identity it may use #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
91fcf7c
feat: let a negentropy reconciliation say which identity it may use
nogringo 47407e9
style: dart format
nogringo 13ebe8d
fix: raise an impossible reconciliation from the call, not from its f…
nogringo 48a3fdb
fix: stop spending the reconciliation budget on waiting for a signer
nogringo 4dea6c3
test: keep a NEG-OPEN on the record once its negotiation is over
nogringo 5264d99
fix: end a reconciliation whose signer refuses to answer the challenge
nogringo 7c3ed9f
Merge remote-tracking branch 'origin/master' into feat/relay-auth-nip77
nogringo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Preserve the reduced timeout budget after a resume.
When an unauthenticated
NEG-OPENis refused, the authentication retry can pause and resume the timeout. A subsequent refusal can pause it again. Because_startTimeout(remaining)does not update_timeoutDuration, the second pause subtracts elapsed time from the original duration and restores consumed budget. Update_timeoutDurationwhen_startTimeoutstarts the timer.Proposed fix
void startTimeout(Duration duration, void Function() onTimeout) { - _timeoutDuration = duration; _onTimeout = onTimeout; _startTimeout(duration); } void _startTimeout(Duration duration) { + _timeoutDuration = duration; _timeoutStartedAt = DateTime.now(); _timeoutTimer = Timer(duration, () => _onTimeout?.call()); }🤖 Prompt for AI Agents