Repository navigation
fix: make CI pass on Windows and Linux - #1
Merged
Merged
Conversation
Normalize text files to LF so Prettier's format check passes on Windows checkouts, and let the stderr stack trace reach the parent before the stdout line that should follow it in the process test fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: CI on
mainfails in every job. On Windows, Prettier's format check flags all 72 files because the checkout converts them to CRLF. On Linux, the process test fails (expected 3 to be greater than 5) because the fixture's stdout line can arrive before its stderr stack trace.After: All jobs pass. Six consecutive full test runs passed in a Linux container (node:24), and the full
npm run checkpasses on Windows.How: A
.gitattributeskeeps text files as LF in every checkout. The emitter fixture waits 100 ms before printing the stdout line that should flush the stderr stack trace, since the two pipes are not ordered relative to each other.