feat: add Filament icon alias support for UI customization#31
Open
kaungkhantjc wants to merge 6 commits into
Open
feat: add Filament icon alias support for UI customization#31kaungkhantjc wants to merge 6 commits into
kaungkhantjc wants to merge 6 commits into
Conversation
Author
|
Hi @AsmitNepali , just a quick heads-up. I realized after submitting that I accidentally committed these changes directly to my fork's 1.x branch instead of creating a separate feature branch. The PR should still merge perfectly, but please let me know if you need me to close this and re-submit it from a feature branch instead. Thanks! |
Collaborator
|
Hi @kaungkhantjc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! 👋
First, thank you so much for this very awesome library ❤️! It's incredibly clean, well thought out, and an absolute joy to use.
I am submitting a PR to introduce Filament's built-in Icon Alias feature to the package. This allows us to easily replace the default Heroicons used throughout the package (timeline, relation managers, header actions, operation types) with their own custom icons, entirely avoiding the need to customize every component, publish or override Blade views.
Sample Usage:
Developers can now effortlessly override default icons directly in their service providers:
Changes Included:
ActivityLogIconAliasclass containing constants for all customizable icons.FilamentIcon::register()in theActivityLogServiceProvider>packageBooted()method.<x-filament::icon :alias="...">andFilamentIcon::resolve().IconAliasTest.php) to ensure defaults register correctly and can be overridden.README.mdlist.All tests are passing locally! Please let me know if you need any tweaks or changes. Thanks again for your hard work on this!