Add visible empty state to activity-log timeline#28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the minimal, easy-to-miss empty-state paragraph in the activity-log timeline with a proper centered empty state (muted history icon + message), and exposes a way to configure the message from the relation manager.
Changes
resources/views/timeline.blade.php— empty state is now a centered block with ari-history-lineicon and the message, instead of a small left-aligned gray<p>. Renders clearly instead of looking like a blank panel.src/Filament/RelationManagers/ActivityLogRelationManager.php— added apublic static ?string $emptyStateand now passes it (falling back to theactivity-log::messages.empty_statetranslation) into the Livewire component. Previously the relation manager mounted the component without an empty-state value, so host apps had no way to set the message on this path.Why
When a record had no activity, the timeline rendered an empty-looking white section. The message now displays prominently, and host apps can customize it via:
empty_state),ActivityLogRelationManager::$emptyState, orTesting
vendor/bin/pest— 46 passed