Center timeline connector line on entry icons#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-centers the vertical connector line in the activity-log timeline so it runs through the middle of each entry's icon, with even gaps above and below every icon.
Why
The connector was positioned with a hardcoded
left-[22px]on a 1px-wide line. Anchoring a 1px line at the icon's center coordinate draws it half a pixel to the right of the axis, so on most displays it visibly leaned off-center. The line also ran fromtop-9to each row'sbottom-0, leaving a small gap below an icon but a larger gap above the next one.How
left-2matches the entry'spx-2,w-7matches the 28px icon grid column) and center it withjustify-center— no pixel math, structurally centered on the true 22px axis.-bottom-2) so the gap above and below each icon is symmetric.Applied to both the grouped and ungrouped timeline branches. All 46 tests pass.