penguin: fix compiled env module build in CI#8
Merged
Conversation
The v0.0.8 release shipped without any compiled CPUArchState CFFI modules: ffi.compile() needs Python.h, the builder image lacks python3-dev, and penguin-env-cffi-gen.py's per-target fallback quietly shipped ABI headers only. Install python3-dev and gate the release on lib/penguin-qemu-env/ being present in the package so a silent fallback cannot publish again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.0.8 shipped without any compiled CPUArchState CFFI modules (
lib/penguin-qemu-env/is absent from the package and no manifest entry has anenv_modulekey):ffi.compile()needsPython.h, the builder image lackspython3-dev(build-essentialdoes not provide it), andpenguin-env-cffi-gen.py's per-target fallback quietly shipped the ABI headers only — which is why the release still succeeded.Two changes:
python3-devin the builder image.lib/penguin-qemu-env/to the release artifact verification inpublish.yml, so a silent header-only fallback can never publish again.No penguin-side change needed once the next release ships: the compat shim already prefers compiled modules via the manifest and currently falls back to the ABI headers (verified working against the v0.0.8 artifact).
Follow-up to #7.