Drop stale llm_knowledge_base docs + dead OpenAI consumer#833
Merged
Conversation
This was referenced Jun 11, 2026
docs/llm_knowledge_base/{playbook,plugins}.md had drifted out of sync with the
tool and are actively misleading to an LLM agent reading them:
- wrong output filenames: console.txt/env_missing.txt/pseudofiles_failures.txt
/pseudofiles_modeled.txt and base/fs.tar — the real files are console.log,
env_missing.yaml, pseudofiles_failures.yaml, pseudofiles_modeled.yaml,
base/fs.tar.gz.
- references makeuboot.py, which does not exist in the tree.
- describes per-change "tools" (add_pseudofile, environment_variable) that don't
exist — Penguin is driven by YAML config edits + `penguin run`, not a tool API.
Its only consumer was src/penguin/llm.py (an OpenAI gpt-4o Assistants/vector-store
integration) via GraphSearch.select_best_config_llm(). That path is dead and
broken: the sole caller is commented out (graphs.py), upload_knowledge_files()
references an undefined self.KNOWLEDGE_DIR, it uses deprecated openai.beta APIs,
and `openai` isn't a declared dependency. Removing it with the docs.
- rm docs/llm_knowledge_base/
- rm src/penguin/llm.py
- graphs.py: drop the `from . import llm` import, the dead select_best_config_llm
method, and the commented-out caller. (UUID import retained; still used.)
The maintained agent-facing guidance now lives in the penguin-pilot context pack.
775406d to
8f1505a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
docs/llm_knowledge_base/{playbook,plugins}.mdand the only code that consumed them (src/penguin/llm.py+ the deadGraphSearch.select_best_config_llmpath).Why
The
llm_knowledge_basedocs have drifted out of sync with the tool and are actively misleading to an LLM agent that reads them:console.txt,env_missing.txt,pseudofiles_failures.txt,pseudofiles_modeled.txt,base/fs.tar. The real artifacts areconsole.log,env_missing.yaml,pseudofiles_failures.yaml,pseudofiles_modeled.yaml,base/fs.tar.gz(verified inpyplugins/analysis/env.py,pyplugins/hyperfile/pseudofile_tracker.py).makeuboot.py"; no such file exists in the tree.add_pseudofiletool", "yourenvironment_variabletool". Penguin has no such tool API; it is driven by editing the YAML config and re-runningpenguin run.The docs' only consumer is
src/penguin/llm.py— an OpenAI gpt-4o Assistants/vector-store integration reached viaGraphSearch.select_best_config_llm(). That path is dead and broken:graphs.py);upload_knowledge_files()references an undefinedself.KNOWLEDGE_DIR;openai.betaAssistants/vector-store APIs;openaiis not a declared dependency.Changes
rm docs/llm_knowledge_base/rm src/penguin/llm.pygraphs.py: drop thefrom . import llmimport, the deadselect_best_config_llmmethod, and its commented-out caller. (UUIDimport retained — still used elsewhere.)graphs.pycompiles and flake8 is clean. The maintained agent-facing guidance now lives in the penguin-pilot context pack.