Skip to content

Drop stale llm_knowledge_base docs + dead OpenAI consumer#833

Merged
lacraig2 merged 1 commit into
mainfrom
drop-stale-llm-knowledge-base
Jun 11, 2026
Merged

Drop stale llm_knowledge_base docs + dead OpenAI consumer#833
lacraig2 merged 1 commit into
mainfrom
drop-stale-llm-knowledge-base

Conversation

@lacraig2

Copy link
Copy Markdown
Collaborator

What

Removes docs/llm_knowledge_base/{playbook,plugins}.md and the only code that consumed them (src/penguin/llm.py + the dead GraphSearch.select_best_config_llm path).

Why

The llm_knowledge_base docs have drifted out of sync with the tool and are actively misleading to an LLM agent that reads them:

  • Wrong output filenames — they say console.txt, env_missing.txt, pseudofiles_failures.txt, pseudofiles_modeled.txt, base/fs.tar. The real artifacts are console.log, env_missing.yaml, pseudofiles_failures.yaml, pseudofiles_modeled.yaml, base/fs.tar.gz (verified in pyplugins/analysis/env.py, pyplugins/hyperfile/pseudofile_tracker.py).
  • Nonexistent script — they tell the reader to "customize makeuboot.py"; no such file exists in the tree.
  • Imaginary tool interface — "invoke your add_pseudofile tool", "your environment_variable tool". Penguin has no such tool API; it is driven by editing the YAML config and re-running penguin run.

The docs' only consumer is src/penguin/llm.py — an OpenAI gpt-4o Assistants/vector-store integration reached via GraphSearch.select_best_config_llm(). That path is dead and broken:

  • its sole caller is commented out (graphs.py);
  • upload_knowledge_files() references an undefined self.KNOWLEDGE_DIR;
  • it uses deprecated openai.beta Assistants/vector-store APIs;
  • openai is not a declared dependency.

Changes

  • rm docs/llm_knowledge_base/
  • rm src/penguin/llm.py
  • graphs.py: drop the from . import llm import, the dead select_best_config_llm method, and its commented-out caller. (UUID import retained — still used elsewhere.)

graphs.py compiles and flake8 is clean. The maintained agent-facing guidance now lives in the penguin-pilot context pack.

docs/llm_knowledge_base/{playbook,plugins}.md had drifted out of sync with the
tool and are actively misleading to an LLM agent reading them:
- wrong output filenames: console.txt/env_missing.txt/pseudofiles_failures.txt
  /pseudofiles_modeled.txt and base/fs.tar — the real files are console.log,
  env_missing.yaml, pseudofiles_failures.yaml, pseudofiles_modeled.yaml,
  base/fs.tar.gz.
- references makeuboot.py, which does not exist in the tree.
- describes per-change "tools" (add_pseudofile, environment_variable) that don't
  exist — Penguin is driven by YAML config edits + `penguin run`, not a tool API.

Its only consumer was src/penguin/llm.py (an OpenAI gpt-4o Assistants/vector-store
integration) via GraphSearch.select_best_config_llm(). That path is dead and
broken: the sole caller is commented out (graphs.py), upload_knowledge_files()
references an undefined self.KNOWLEDGE_DIR, it uses deprecated openai.beta APIs,
and `openai` isn't a declared dependency. Removing it with the docs.

- rm docs/llm_knowledge_base/
- rm src/penguin/llm.py
- graphs.py: drop the `from . import llm` import, the dead select_best_config_llm
  method, and the commented-out caller. (UUID import retained; still used.)

The maintained agent-facing guidance now lives in the penguin-pilot context pack.
@lacraig2 lacraig2 force-pushed the drop-stale-llm-knowledge-base branch from 775406d to 8f1505a Compare June 11, 2026 03:01
@lacraig2 lacraig2 enabled auto-merge (rebase) June 11, 2026 03:22
@lacraig2 lacraig2 merged commit 821e3df into main Jun 11, 2026
14 checks passed
@lacraig2 lacraig2 deleted the drop-stale-llm-knowledge-base branch June 11, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant