Drop broken 32-bit ltrace fallback for mips64#9
Merged
Conversation
mips64eb/mips64el are in iglooExcludedArchs (no 64-bit MIPS ltrace build), and iglooFallbackArchs symlinked them to the 32-bit mipsel/mipseb ltrace. That symlink can't run on a mips64 guest: the 32-bit binary needs the 32-bit musl loader + libc, but penguin only mounts the arch's own 64-bit /igloo/dylibs, so 'ltrace -V' fails with an ELF/ABI mismatch and breaks the penguin-tools actuation test. Drop the fallback so mips64 ships no ltrace, matching riscv64/loongarch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mips64eb/mips64el have no native ltrace build (already in
iglooExcludedArchs), andiglooFallbackArchssymlinked them to the 32-bit mipsel/mipseb ltrace.That fallback can't work on a mips64 guest: the 32-bit ltrace needs the 32-bit musl loader + libc, but penguin only mounts the arch's own (64-bit)
/igloo/dylibs, so running it gives an ELF/ABI mismatch (Invalid ELF image for this architecture).ltrace -Vthen fails and breaks penguin's penguin-tools actuation test on mips64.Drop the fallback so mips64 simply ships no ltrace, consistent with riscv64/loongarch. Verified via core/qemu that the symlinked 32-bit binary is the failure source on mips64el/eb.