Use canonical arch names only; drop colliding compat aliases#4
Merged
Conversation
The arm64/ppc64/ppc64el/loongarch compat aliases (added so penguin-tools could supply the legacy dylib dir names hyperfs used) collide with the real directories hyperfs still ships under those exact names: extracting the tarball over them makes tar fail (symlink-over-directory), breaking the penguin image build while hyperfs is present. These legacy names are only needed once hyperfs is gone, so the bridging belongs in penguin's hyperfs-removal change, not here. Keep penguin-tools on canonical names (matching busybox), which merge cleanly into the shared arch dirs. The pre-existing intel64/powerpc64el aliases stay -- they don't match any hyperfs dir name, so they don't collide. Verified the aarch64 bundle emits aarch64 + dylibs/aarch64 only (no arm64), and still passes the runtime link-closure check.
lacraig2
added a commit
to rehosting/penguin
that referenced
this pull request
Jun 8, 2026
v0.0.2 shipped legacy compat dir symlinks (arm64/ppc64/ppc64el/loongarch) that collide with the directories hyperfs still ships under those names, making tar fail when extracting over them. v0.0.3 (rehosting/penguin-tools#4) reverts to canonical names only, which merge cleanly. Blocked on that release.
lacraig2
added a commit
to rehosting/penguin
that referenced
this pull request
Jun 8, 2026
v0.0.2 shipped legacy compat dir symlinks (arm64/ppc64/ppc64el/loongarch) that collide with the directories hyperfs still ships under those names, making tar fail when extracting over them. v0.0.3 (rehosting/penguin-tools#4) reverts to canonical names only, which merge cleanly. Blocked on that release.
lacraig2
added a commit
to rehosting/penguin
that referenced
this pull request
Jun 9, 2026
v0.0.2 shipped legacy compat dir symlinks (arm64/ppc64/ppc64el/loongarch) that collide with the directories hyperfs still ships under those names, making tar fail when extracting over them. v0.0.3 (rehosting/penguin-tools#4) reverts to canonical names only, which merge cleanly. Blocked on that release.
lacraig2
added a commit
to rehosting/penguin
that referenced
this pull request
Jun 9, 2026
v0.0.2 shipped legacy compat dir symlinks (arm64/ppc64/ppc64el/loongarch) that collide with the directories hyperfs still ships under those names, making tar fail when extracting over them. v0.0.3 (rehosting/penguin-tools#4) reverts to canonical names only, which merge cleanly. Blocked on that release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the
arm64/ppc64/ppc64el/loongarchcompat aliases added in v0.0.2.Why: those names exactly match the real directories hyperfs still ships, so extracting penguin-tools over them makes
tarfail (symlink-over-directory, exit 2) — which would break the penguin image build while hyperfs is present (rehosting/penguin#823). I confirmed this with a direct extraction test.The legacy names are only needed after hyperfs is removed, so that bridging belongs in penguin's hyperfs-removal change, not here. penguin-tools stays on canonical names (same as busybox), which merge cleanly into the shared arch dirs. The pre-existing
intel64/powerpc64elaliases are kept — they don't match any hyperfs dir name.Verified the aarch64 bundle emits
aarch64+dylibs/aarch64only (noarm64) and still passes the runtime link-closure check.