Repository navigation
chore(gitignore): ignore all .env* files, keep example templates - #3809
Conversation
The existing rules cover .env and .env.*, but not names without the dot such as .envrc or .env-staging. Those can hold secrets too. Add a catch-all .env* rule and re-allow the .env.example and .env.*.example templates after it, so they stay tracked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 264f9e73-c356-47a1-b538-edcaf050e353) |
PR Blocker ChecklistHead SHA: Status: Ready
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
REVIEW: PASS codex 1bf5d97 Codex CLI review run by a Claude Code session on the exact head above. No blocking problems found at |
Brings in #3780 (relative imports in three ingestion modules plus the test_no_absolute_app_imports guard), #3793, #3794, #3807 and #3809. Both conflicts (stripe_billing/rate_limiting.py, webhook_compat.py) were the same relative-import change made on both sides; main's wording kept. The new guard test, the WI-02 bare-import guard, the route snapshot test and the repository gates pass on the merged tree. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GyhDYGPjbfDzVjRUqkvz4B
Brings in #3780 (relative imports in three ingestion modules plus the test_no_absolute_app_imports guard), #3793, #3794, #3807 and #3809. Both conflicts (stripe_billing/rate_limiting.py, webhook_compat.py) were the same relative-import change made on both sides; main's wording kept. The new guard test, the WI-02 bare-import guard, the route snapshot test and the repository gates pass on the merged tree. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GyhDYGPjbfDzVjRUqkvz4B
Summary
.env*ignore rule. The existing.envand.env.*rules miss names like.envrcand.env-staging, which can hold secrets..env.exampleand.env.*.exampleafter the new rule, so the templates stay tracked.This came out of the work on #3782 but is unrelated to EDI, so it is separate.
Verification
git check-ignoreconfirms.envrc,.env-staging,.env.prodandfrontend/.envrcare ignored..envtemplates still resolve to the!rules..gitignoreonly, so no app tests or/verifywere run.🤖 Generated with Claude Code
Note
Low Risk
.gitignoreonly; reduces accidental commit of secrets with no runtime or auth behavior changes.Overview
Adds a catch-all
.env*rule at the bottom of.gitignoreso variant env files (e.g..envrc,.env-staging) are ignored even when they do not match the existing.env/.env.*entries.Immediately after that rule,
!.env.exampleand!.env.*.exampleare re-applied so safe template files stay tracked and are not swallowed by the broader pattern.Reviewed by Cursor Bugbot for commit 1bf5d97. Bugbot is set up for automated code reviews on this repo. Configure here.