Skip to content

chore(gitignore): ignore all .env* files, keep example templates - #3809

Merged
PetrefiedThunder merged 1 commit into
mainfrom
claude/gitignore-env-catchall
Nov 4, 2026
Merged

PetrefiedThunder merged 1 commit into
mainfrom
claude/gitignore-env-catchall

Conversation

@PetrefiedThunder

@PetrefiedThunder PetrefiedThunder commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a catch-all .env* ignore rule. The existing .env and .env.* rules miss names like .envrc and .env-staging, which can hold secrets.
  • Re-allows .env.example and .env.*.example after the new rule, so the templates stay tracked.

This came out of the work on #3782 but is unrelated to EDI, so it is separate.

Verification

  • git check-ignore confirms .envrc, .env-staging, .env.prod and frontend/.envrc are ignored.
  • All five tracked .env templates still resolve to the ! rules.
  • .gitignore only, so no app tests or /verify were run.

🤖 Generated with Claude Code


Note

Low Risk
.gitignore only; reduces accidental commit of secrets with no runtime or auth behavior changes.

Overview
Adds a catch-all .env* rule at the bottom of .gitignore so variant env files (e.g. .envrc, .env-staging) are ignored even when they do not match the existing .env / .env.* entries.

Immediately after that rule, !.env.example and !.env.*.example are re-applied so safe template files stay tracked and are not swallowed by the broader pattern.

Reviewed by Cursor Bugbot for commit 1bf5d97. Bugbot is set up for automated code reviews on this repo. Configure here.

The existing rules cover .env and .env.*, but not names without the dot
such as .envrc or .env-staging. Those can hold secrets too.

Add a catch-all .env* rule and re-allow the .env.example and
.env.*.example templates after it, so they stay tracked.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
regengine Ready Ready Preview Nov 4, 2026 5:31am UTC

Request Review

@cursor

cursor Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 264f9e73-c356-47a1-b538-edcaf050e353)

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

PR Blocker Checklist

Head SHA: 1bf5d973a4df393013bb530d74b3177e52593bcf

Status: Ready

  • All review threads resolved
  • No reviews requesting changes
  • No blocked review engines

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The .gitignore file now ignores .env* paths and re-includes .env.example and .env.*.example template files.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Minimal · up to 1bf5d

This change safely ignores environment files while preserving all tracked example templates. No actionable merge-blocking risk remains.

Architecture risk: Low · up to 1bf5d

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .gitignore: Adds a broad .env* ignore pattern and exceptions for .env.example and scoped .env.*.example templates.
Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the change and verification steps, but it omits the required Type of Change, Checklist, and Related Issues sections. It also uses a Verification section instead of the require… Add the required Type of Change, Test Plan, Checklist, and Related Issues sections. Mark applicable options and state that the change is configuration-only if no application tests were needed. Preserve the existing verification details unde…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: ignoring .env* files while keeping example templates tracked.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the change and verification steps, but it omits the required Type of Change, Checklist, and Related Issues sections. It also uses a Verification section instead of the required Test Plan section.

Resolution

Add the required Type of Change, Test Plan, Checklist, and Related Issues sections. Mark applicable options and state that the change is configuration-only if no application tests were needed. Preserve the existing verification details under Test Plan or an equivalent clearly labeled section.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 77dd495 and 1bf5d97.

Files selected for processing: 1
  • .gitignore

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T05:32:40.708122Z 1bf5d97 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@PetrefiedThunder

Copy link
Copy Markdown
Collaborator Author

REVIEW: PASS codex 1bf5d97

Codex CLI review run by a Claude Code session on the exact head above.

No blocking problems found at 1bf5d973. The .gitignore change matches its claims: git check-ignore confirms the listed environment-file variants are ignored and all five tracked templates remain allowed. No runtime, tenant isolation, or public-copy changes. The description mentions no unresolved bot threads.

@PetrefiedThunder
PetrefiedThunder merged commit 07126f6 into main Nov 4, 2026
57 of 59 checks passed
@PetrefiedThunder
PetrefiedThunder deleted the claude/gitignore-env-catchall branch November 4, 2026 07:56
PetrefiedThunder pushed a commit that referenced this pull request Nov 4, 2026
Brings in #3780 (relative imports in three ingestion modules plus the
test_no_absolute_app_imports guard), #3793, #3794, #3807 and #3809. Both
conflicts (stripe_billing/rate_limiting.py, webhook_compat.py) were the same
relative-import change made on both sides; main's wording kept. The new
guard test, the WI-02 bare-import guard, the route snapshot test and the
repository gates pass on the merged tree.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GyhDYGPjbfDzVjRUqkvz4B
PetrefiedThunder pushed a commit that referenced this pull request Nov 5, 2026
Brings in #3780 (relative imports in three ingestion modules plus the
test_no_absolute_app_imports guard), #3793, #3794, #3807 and #3809. Both
conflicts (stripe_billing/rate_limiting.py, webhook_compat.py) were the same
relative-import change made on both sides; main's wording kept. The new
guard test, the WI-02 bare-import guard, the route snapshot test and the
repository gates pass on the merged tree.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GyhDYGPjbfDzVjRUqkvz4B

This branch was successfully deployed

1 active deployment
Preview — 1bf5d973 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants