Repository navigation
fix(frontend): remove unused axios dependency - #3794
Conversation
Grep found no import/require of axios in app or test source; only the package.json entry, docs examples, comments, and a vestigial vi.mock. Drop axios (~1.20.0) and refresh the lockfile. npm audit: 0 high/critical (4 moderate via @sentry/nextjs → glob, unchanged by this change). Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description follows the template sections (Summary, Test Plan evidence, verification). It explains the removal, the grep evidence that nothing imports axios, and the test, build, lint, and audit r… | Add the Type of Change selection (for this PR, Bug fix or Refactor, as the author decides). Tick the applicable Test Plan items. The author ran tests, build, and lint, so the Test Plan should reflect those. Complete the Checklist items. Add… |
-
Check name Status Explanation Title check The title names the main change: removing the unused axios dependency from the frontend. The raw summary confirms that only frontend/package.json changes, with the axios entry removed. The title uses … Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the main change: removing the unused axios dependency from the frontend. The raw summary confirms that only frontend/package.json changes, with the axios entry removed. The title uses the conventional-commit form and is specific and accurate.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.
-
Full details: Description check
-
Explanation
The description follows the template sections (Summary, Test Plan evidence, verification). It explains the removal, the grep evidence that nothing imports axios, and the test, build, lint, and audit results. Gaps: the Summary has no 'Type of Change' checkboxes, the Test Plan and Checklist items are not ticked, and the Related Issues section is empty. It does not link PR
#3794or an issue. The author gives verification detail, but the template's required checklist and type selection are missing.Resolution
Add the Type of Change selection (for this PR, Bug fix or Refactor, as the author decides). Tick the applicable Test Plan items. The author ran tests, build, and lint, so the Test Plan should reflect those. Complete the Checklist items. Add a Related Issues entry if one exists, or state that none applies. Also remove the 'Do not merge' line from the description. It is a process note and does not belong in the PR body.
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
PR Blocker ChecklistHead SHA: Status: Ready
|
✅ Bundle Size Report
Bundle is within the 10.0MB limit. |
github-actions
Bot
added
dependencies
|
Vercel preview: https://regengine-ia38o8mab-petrefiedthunders-projects.vercel.app Access is via Vercel login (Deployment Protection). |
PetrefiedThunder
left a comment
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: PASS deepseek 9641a11
Axios removal only (frontend/package.json + lock). No real import/require of axios remains (api-client uses fetch); leftover vi.mock('axios') in admin.test.ts is dead and tests still pass. follow-redirects override kept. Lock churn is axios+transitive removal plus optional @rollup/rollup-linux-* metadata — no direct-dep version drift. Local (box, Mac offline): npm ci, tsc --noEmit, lint (0 errors), vitest __tests__ 1482 pass, next build, npm ls axios empty, npm audit 4 moderate (sentry/glob, pre-existing). CI green aside from gate-only Engine Review Pass.
Brings in #3780 (relative imports in three ingestion modules plus the test_no_absolute_app_imports guard), #3793, #3794, #3807 and #3809. Both conflicts (stripe_billing/rate_limiting.py, webhook_compat.py) were the same relative-import change made on both sides; main's wording kept. The new guard test, the WI-02 bare-import guard, the route snapshot test and the repository gates pass on the merged tree. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GyhDYGPjbfDzVjRUqkvz4B
Merge commit only (no rebase). One conflict, in frontend/package-lock.json: this branch's ea0ce2f ported #3773 byte for byte, #3773 has since merged, and main changed the lockfile again (#3794 removed axios). This PR carries no dependency change of its own, so the dependency files (frontend/package.json, frontend/package-lock.json, requirements.in, requirements.lock, packages/factory-local/requirements*) are taken from main. The diff against main is the PR's own 11 files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GyhDYG3ddQvVKyu2qtYfCj
Summary
Removes the unused
axios(~1.20.0) dependency from the frontend. HTTP goes through the in-repoapi-client(fetch), not axios.Grep evidence
from 'axios'/require('axios')/ dynamic import anywhere outside docs.docs/tenant/API_EXAMPLES.md(example snippets), comments incsrf.ts/ ADR docs, a vestigialvi.mock('axios')inadmin.test.ts(tests do not exercise it), and helper names likeaxiosRejection/isAxiosErrorshape flags — none import the package.frontend/package.jsonandfrontend/package-lock.jsonchange.Verification
v24.22.1/ npm11.21.1npm installrefreshed the lockfile (axios + its exclusive transitives removed)npm audit: 0 high / 0 critical; 4 moderate (globvia@sentry/nextjs, pre-existing; not addressed here; nonpm audit fix --force)npm run test:run: 206 files / 1647 passed (1 expected fail, 2 skipped)npm run build: successnpm run lint: exit 0 (0 errors, 60 pre-existing warnings); design-lint cleanBase includes #3770 (
a42029b9). Head:9641a11ea42fd4ffbd9512eb938a7df64051ccdd.Do not merge from this PR description — leave merge to DevOps after engine review.
Note
Low Risk
No application code changes; only removes an unused package with no remaining imports.
Overview
Removes the unused
axiosdependency from the frontend (package.jsonand lockfile). Runtime HTTP already goes through the in-repoapi-client(fetch), so this is dependency cleanup only.The lockfile refresh also drops axios-only transitives (e.g.
form-data,follow-redirects,https-proxy-agent) and adjusts optional Rollup platform entries as part ofnpm install.Reviewed by Cursor Bugbot for commit 9641a11. Bugbot is set up for automated code reviews on this repo. Configure here.