Skip to content

chore(secrets): refresh .secrets.baseline line-number drift - #3700

Closed
PetrefiedThunder wants to merge 1 commit into
mainfrom
chore/secrets-baseline-refresh-2026-10-28
Closed

PetrefiedThunder wants to merge 1 commit into
mainfrom
chore/secrets-baseline-refresh-2026-10-28

Conversation

@PetrefiedThunder

@PetrefiedThunder PetrefiedThunder commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

The security workflow's Secrets Audit step fails on main (exit 3: "The baseline file was updated") because baseline line numbers drifted; no new findings. Refreshed with detect-secrets 1.5.0 using the exact security.yml command (generated by Codex in a fresh temp clone, verified independently). Diff: 6 line_number values + generated_at only; all 452 entries unchanged.

Infra sweep 2026-10-28 ~4 AM PT.


Note

Low Risk
Metadata-only baseline refresh with no new or removed secret findings; no runtime or application code changes.

Overview
Updates .secrets.baseline so the Secrets Audit step stops failing with “baseline file was updated” after unrelated edits shifted line numbers in a handful of test files. The refresh was done with detect-secrets 1.5.0, matching CI/pre-commit.

Only six existing entries had their line_number metadata adjusted (frontend session-origin, api-security JWT fixture, graph labels security test); hashed_secret values and the rest of the baseline are unchanged. generated_at was bumped to the new scan time.

Reviewed by Cursor Bugbot for commit 055b12f. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
regengine Ready Ready Preview Oct 28, 2026 11:22am UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T11:21:44.111813Z 055b12f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 51655f9 and 055b12f.

Files selected for processing: 1
  • .secrets.baseline

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

Walkthrough

The secrets baseline updates recorded source line numbers for six findings across three test files. It also updates the baseline generation timestamp. Finding types, hashes, verification values, and detector configuration do not change.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Minimal · up to 055b1

The refresh is limited to accurate secret-finding locations and generation metadata, with no identified merge-blocking risk.

Architecture risk: Low · up to 055b1

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .secrets.baseline: The baseline entries for four findings in frontend/src/__tests__/api/session-origin.test.ts now record source lines 251, 276, 305, and 332 instead of 250, 275, 304, and 331; their finding types, hashes, and verification values remain unchanged.
  • observed — Modified behavior in .secrets.baseline: The recorded source line for the JWT finding in frontend/src/test/security/api-security.test.ts changes from 133 to 148.
  • observed — Modified behavior in .secrets.baseline: The recorded source line for the finding in services/graph/tests/test_labels_security.py changes from 205 to 272.
  • observed — Modified behavior in .secrets.baseline: The baseline generation timestamp changes from 2026-10-26T14:49:21Z to 2026-10-28T11:15:47Z.
Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the main change: refreshing the .secrets.baseline file to fix line-number drift. The raw summary confirms that the only changes are six updated line numbers and a new generated_at time…
Description check Passed The description covers the core of the change. It states the problem (Secrets Audit step fails on main with exit 3), the fix (baseline refreshed with detect-secrets 1.5.0 using the exact security.yml …
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: refreshing the .secrets.baseline file to fix line-number drift. The raw summary confirms that the only changes are six updated line numbers and a new generated_at timestamp, so the title matches the changeset. It uses the conventional chore(secrets) prefix and is specific.

Full details: Description check

Explanation

The description covers the core of the change. It states the problem (Secrets Audit step fails on main with exit 3), the fix (baseline refreshed with detect-secrets 1.5.0 using the exact security.yml command), and the scope of the diff (6 line_number values plus generated_at, all 452 entries unchanged). The template's Summary, Type of Change, Test Plan, Checklist, and Related Issues sections are missing. The description also does not say which checklist item applies, such as the hardcoded-secrets check. These gaps are minor for a generated baseline refresh, so the description is mostly complete.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

PR Blocker Checklist

Head SHA: 055b12fb5c2377d45b8e7a33ed271eadb39f8043

Status: Ready

  • All review threads resolved
  • No reviews requesting changes
  • No blocked review engines

@PetrefiedThunder

Copy link
Copy Markdown
Collaborator Author

Duplicate of #3703, closed per VS Code Lead; branch kept

This branch was successfully deployed

1 active deployment
Preview — 055b12fb Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant