copy: qualify hashing claims (trace, supplier-compliance, export) by PetrefiedThunder · Pull Request #3672 · regengine/RegEngine

PetrefiedThunder · 2026-10-27T04:45:19Z

Summary

Trace, supplier-compliance and export pages: hashing claims qualified as 'where enabled' RegEngine feature, not FDA requirement.
Requested by Legal: Lead Counsel (memo fsma204-status-and-copy-flags). Compliance date stays Jan 20, 2026 (87 FR 70910); FDA has said it will not enforce before July 20, 2028 per a Congressional directive.
Replaces copy: qualify hashing claims (trace, supplier-compliance, export) #3664 (re-opened from an engine-prefixed branch with a Conventional Commit; same content, on current main). Author engine: codex; reviewer engine: claude.

Type of Change

Test Plan

Unit tests added/updated
Integration tests pass
Manual testing performed
N/A (copy-only text change; CI covers build/tests)

Checklist

My code follows the existing patterns in the codebase
I have not introduced hardcoded secrets or credentials
If this PR adds a test that uses sys.modules[X] = stub, I justified it in the PR description (N/A, none added)
I have updated relevant documentation (if applicable)
My changes generate no new warnings or lint errors (relying on CI Lint & Format; not run locally)

Related Issues

Relates to #3664

vercel · 2026-10-27T04:45:25Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
regengine	Ready	Preview	Oct 27, 2026 4:46am UTC

chatgpt-codex-connector · 2026-10-27T04:45:32Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-27T04:46:06.180570Z	`a237f04`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-27T04:47:10Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: regengine/RegEngine
Branch: codex/legal-hashing-qualifiers
File: .coderabbit.yaml
Commit: a237f04
Layers: Repository YAML
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 9416c350-52da-4438-94b1-7f7df296751d

Commits

Reviewing files that changed from the base of the PR and between 1f69633 and a237f04.

Files selected for processing: 3

frontend/src/app/supplier-compliance/page.tsx
frontend/src/app/tools/export/page.tsx
frontend/src/app/trace/page.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

Walkthrough

The supplier security FAQ, export package descriptions, and event timeline description now qualify hashing-related claims with “where enabled.” The descriptions also state that hashing is a RegEngine feature, not an FDA requirement. The package manifest description replaces its claim of independent verification without RegEngine with a conditional statement about checking content hashes.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Merge Risk: Minimal · up to a237f

The PR safely updates user-facing descriptions without changing application behavior.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: qualifying hashing claims on the trace, supplier-compliance, and export surfaces.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The PR description is mostly complete. It has a clear summary of the copy changes, a type of change selection (Bug fix and Documentation), a test plan marked N/A with a reason, a completed checklist, …

Full details: Description check

Explanation

The PR description is mostly complete. It has a clear summary of the copy changes, a type of change selection (Bug fix and Documentation), a test plan marked N/A with a reason, a completed checklist, and a related issue link (#3664). It explains the regulatory context (Legal request, compliance date, the 87 FR 70910 reference) and the replacement of PR #3664. Minor gaps: the Type of Change selects 'Bug fix' alongside 'Documentation' for a copy-only wording change, which is a questionable classification. The lint checkbox is unchecked with a note that CI covers it. The 'Related Issues' section uses 'Relates to #3664' and the template's example format is followed. The description does not use the template's 'Fixes' or other linking syntax beyond that, which is acceptable.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 3 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

PetrefiedThunder · 2026-10-27T04:48:59Z

Review: `a237f04` (three frontend files, 4 lines changed)

The diff passes. None of the changed lines has a legal problem or a code problem.

Legal accuracy

Hashing claims: all four changed strings are now qualified. Each one says "where enabled", and three of them also say "Hashing is a RegEngine feature, not an FDA requirement." The removed overclaims were "proving record integrity", "Each event cryptographically linked" and "Independent verification without RegEngine". The last one was an unqualified promise you could not always back up, so removing it is right.
Compliance dates: no date appears in the diff. Nothing calls 2028 the compliance date and nothing touches Jan 20, 2026.
21 CFR 1.1300: not mentioned anywhere, so nothing presents it as a coverage determination.

Code safety

Every edit replaces the contents of one string or one JSX text node. None of the new strings has an apostrophe that would break the single quotes. Commas, braces and JSX tags are unchanged.
git show --stat HEAD lists exactly these three files, and nothing else changed.
I did not run npm run build or npm run lint. A change limited to string contents carries little risk.

Outside this diff (not blocking)
The supplier FAQ answer still makes two unchanged claims: "tenant-isolated databases with row-level security" and "only visible to you and the buyer". Both are claims about the security architecture and should get the same legal pass in a later change. I have not checked them against the code.

REVIEW: PASS claude a237f04

github-actions · 2026-10-27T05:05:29Z

✅ Bundle Size Report

Metric	Size
Total JS	5564.2KB (5.43MB)
Total CSS	131.9KB
Limit	10.0MB

Bundle is within the 10.0MB limit.

github-actions · 2026-10-27T05:22:40Z

Vercel preview access note removed (A-2177 secret-hygiene cleanup).
Access is via Vercel login (Deployment Protection).

PetrefiedThunder

REVIEW: PASS muse a237f04

Read the full diff (3 files).

supplier-compliance/page.tsx:73, tools/export/page.tsx:49-54 and trace/page.tsx:343 narrow the claims. "Every submission/each event" becomes "where enabled", "Independent verification without RegEngine" is removed, and "Hashing is a RegEngine feature, not an FDA requirement" is added. This removes overclaims and invents nothing.
No em or en dashes and no made-up data in the added lines. The visual-report failure is non-required, per Lead.

github-actions · 2026-10-27T05:26:29Z

PR Blocker Checklist

Head SHA: a237f045b246d421675d3610d7c8e7712153f1d3

Status: Ready

All review threads resolved
No reviews requesting changes
No blocked review engines

fix(copy): qualify hashing claims on trace, supplier-compliance, export

a237f04

PetrefiedThunder mentioned this pull request Oct 27, 2026

copy: qualify hashing claims (trace, supplier-compliance, export) #3664

Closed

vercel Bot deployed to Preview October 27, 2026 04:46

View deployment

PetrefiedThunder commented Oct 27, 2026

View reviewed changes

github-actions Bot added the frontend label Oct 27, 2026

PetrefiedThunder merged commit d70729d into main Oct 27, 2026
62 of 65 checks passed

PetrefiedThunder deleted the codex/legal-hashing-qualifiers branch October 27, 2026 06:23

Navigation Menu

Repository navigation

copy: qualify hashing claims (trace, supplier-compliance, export) - #3672

copy: qualify hashing claims (trace, supplier-compliance, export)#3672
PetrefiedThunder merged 1 commit into
mainfrom
codex/legal-hashing-qualifiers

PetrefiedThunder commented Oct 27, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

PetrefiedThunder commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026 •

edited by PetrefiedThunder

Loading

Uh oh!

PetrefiedThunder left a comment

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

PetrefiedThunder commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Test Plan

Checklist

Related Issues

Uh oh!

vercel Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PetrefiedThunder commented Oct 27, 2026

Review: a237f04 (three frontend files, 4 lines changed)

Uh oh!

github-actions Bot commented Oct 27, 2026

✅ Bundle Size Report

Uh oh!

github-actions Bot commented Oct 27, 2026 • edited by PetrefiedThunder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 27, 2026

PR Blocker Checklist

Status: Ready

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

PetrefiedThunder commented Oct 27, 2026 •

edited

Loading

vercel Bot commented Oct 27, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 27, 2026 •

edited

Loading

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading

Review: `a237f04` (three frontend files, 4 lines changed)

github-actions Bot commented Oct 27, 2026 •

edited by PetrefiedThunder

Loading